FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-93061: Mark as artificial: backwards jump after async for by sweeneyde · Pull Request #93062 · python/cpython · GitHub

/ cpython Public

gh-93061: Mark as artificial: backwards jump after async for - #93062

Merged
markshannon merged 2 commits into
python:mainfrom
sweeneyde:async_for_end_no_line
May 23, 2022
ConversationCommits (2)ChecksFiles changed
Merged

gh-93061: Mark as artificial: backwards jump after async for#93062
markshannon merged 2 commits into
python:mainfrom
sweeneyde:async_for_end_no_line

Conversation

sweeneyde commented May 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This updates compiler_async_for to match compiler_for.

#93061

sweeneyde requested a review from markshannon as a code owner May 22, 2022 02:34
sweeneyde added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels May 22, 2022

markshannon commented May 23, 2022

Copy link
Copy Markdown
Member

Looks good. Thanks.

markshannon merged commit a458be3 into python:main May 23, 2022

miss-islington commented May 23, 2022

Copy link
Copy Markdown
Contributor

Thanks @sweeneyde for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2022
pythongh-93061: Mark as artificial: backwards jump after async for (p…
d9b5fc6 
…ythonGH-93062)

(cherry picked from commit a458be3)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>

bedevere-bot commented May 23, 2022

Copy link
Copy Markdown

GH-93110 is a backport of this pull request to the 3.11 branch.

miss-islington commented May 23, 2022

Copy link
Copy Markdown
Contributor

Sorry, @sweeneyde and @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a458be3263b4cb92f3fde726461e8ef44b2a4a9d 3.10

bedevere-bot removed the needs backport to 3.11 only security fixes label May 23, 2022
sweeneyde deleted the async_for_end_no_line branch May 23, 2022 14:48
bedevere-bot removed the needs backport to 3.10 only security fixes label May 23, 2022

bedevere-bot commented May 23, 2022

Copy link
Copy Markdown

GH-93120 is a backport of this pull request to the 3.10 branch.

sweeneyde added a commit that referenced this pull request May 23, 2022
gh-93061: Mark as artificial: backwards jump after async for (GH-93062)…
f095058 
… (GH-93110)

(cherry picked from commit a458be3)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

markshannon

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL