FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92728: Restore re.template, but deprecate it by hroncok · Pull Request #93161 · python/cpython · GitHub

/ cpython Public

gh-92728: Restore re.template, but deprecate it - #93161

Merged
serhiy-storchaka merged 9 commits into
python:mainfrom
hroncok:dont_break_compatibility
May 25, 2022
ConversationCommits (9)ChecksFiles changed
Merged

gh-92728: Restore re.template, but deprecate it#93161
serhiy-storchaka merged 9 commits into
python:mainfrom
hroncok:dont_break_compatibility

Conversation

hroncok commented May 24, 2022

Copy link
Copy Markdown
Contributor

No description provided.

hroncok mentioned this pull request May 24, 2022
Closed
hroncok marked this pull request as ready for review May 24, 2022 09:07

hroncok commented May 24, 2022

Copy link
Copy Markdown
Contributor Author

Considering the relevant function/flag was not documented, I have decided not to add a versionchanged thing to the documentation of the re module. Let me know if I should.

hroncok commented May 24, 2022
View reviewed changes
Comment thread Lib/re/__init__.py
serhiy-storchaka self-requested a review May 24, 2022 09:25
serhiy-storchaka approved these changes May 24, 2022
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

Comment thread Lib/re/__init__.py
Comment thread Misc/NEWS.d/next/Library/2022-05-24-10-59-02.gh-issue-92728.zxTifq.rst

hroncok commented May 24, 2022

Copy link
Copy Markdown
Contributor Author

Could you please label this with 3.11 backport?

hroncok commented May 24, 2022
View reviewed changes
Comment thread Lib/test/test_re.py Outdated
serhiy-storchaka added the 3.11 only security fixes label May 25, 2022
serhiy-storchaka merged commit 16a7e4a into python:main May 25, 2022
serhiy-storchaka added needs backport to 3.11 only security fixes and removed 3.11 only security fixes labels May 25, 2022

miss-islington commented May 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @hroncok for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
pythongh-92728: Restore re.template, but deprecate it (pythonGH-93161)
f191b17 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (pythonGH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>

bedevere-bot commented May 25, 2022

Copy link
Copy Markdown

GH-93206 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label May 25, 2022
miss-islington added a commit that referenced this pull request May 25, 2022
gh-92728: Restore re.template, but deprecate it (GH-93161)
74b205b 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (GH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
hroncok deleted the dont_break_compatibility branch May 25, 2022 10:17
wimglenn mentioned this pull request Oct 24, 2024
Closed
donbarbos mentioned this pull request Aug 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL