FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92886: Fixing tests that fail when running with optimizations (`-O`) in `test_zipimport.py` by jackh-ncl · Pull Request #93236 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-92886: Fixing tests that fail when running with optimizations (-O) in test_zipimport.py #93236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 4 commits into from
Jun 10, 2022
Conversation 8 Commits 4 Checks 0 Files changed
Merged

gh-92886: Fixing tests that fail when running with optimizations (-O) in test_zipimport.py #93236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3461fa2
Fixing tests that fail when running with optimizations (`-O`) in `tes…
May 25, 2022
b451da2
📜🤖 Added by blurb_it.
blurb-it[bot] May 25, 2022
a890b25
Add assertion to testDefaultOptimizationLevel to test while running …
Jun 7, 2022
53e0cc8
Merge remote-tracking branch 'origin/92886-zipimport' into 92886-zipi…
Jun 7, 2022
File filter

Filter by extension

Filter by extension .py  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 4 additions & 1 deletion Lib/test/test_zipimport.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,10 @@ def test(val):
sys.path.insert(0, TEMP_ZIP)
mod = importlib.import_module(TESTMOD)
self.assertEqual(mod.test(1), 1)
self.assertRaises(AssertionError, mod.test, False)
if __debug__:
self.assertRaises(AssertionError, mod.test, False)
Comment on lines +657 to +658

brettcannon Jun 7, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
if __debug__:
self.assertRaises(AssertionError, mod.test, False)
if __debug__:
self.assertRaises(AssertionError, mod.test, False)
else:
self.assertEqual(mod.test(0), 0)

else:
self.assertEqual(mod.test(0), 0)

def testImport_WithStuff(self):
# try importing from a zipfile which contains additional
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixing tests that fail when running with optimizations (``-O``) in ``test_zipimport.py``
Back | FazBrowse Home | New Git URL