FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-93243: Make smtpd private before porting its users by arhadthedev · Pull Request #93246 · python/cpython · GitHub

/ cpython Public

gh-93243: Make smtpd private before porting its users - #93246

Merged
miss-islington merged 19 commits into
python:mainfrom
arhadthedev:privatize-smtpd
Aug 6, 2022
ConversationCommits (19)ChecksFiles changed
Merged

gh-93243: Make smtpd private before porting its users#93246
miss-islington merged 19 commits into
python:mainfrom
arhadthedev:privatize-smtpd

Conversation

arhadthedev commented May 26, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

gh-93243

This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).

Automerge-Triggered-By: GH:warsaw

arhadthedev requested review from a team and vsajip as code owners May 26, 2022 06:49
hugovk reviewed Jun 4, 2022
View reviewed changes
Comment thread PCbuild/lib.pyproj
AA-Turner reviewed Jun 4, 2022
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some docs/wording comments:

A

Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Lib/test/mock_socket.py Outdated
Comment thread Lib/test/mock_socket.py Outdated
Comment thread Misc/NEWS.d/next/Library/2022-05-26-08-41-34.gh-issue-93243.uw6x5z.rst Outdated
arhadthedev and others added 4 commits June 4, 2022 19:01
Update Doc/whatsnew/3.12.rst
c7cb1e3 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Update Doc/whatsnew/3.12.rst
8180429 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Address the review of AA-Turner (using suggestion batching)
b70bf5a 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Remove non-working :mod:
4054ac2
AA-Turner reviewed Jun 4, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
Update Doc/whatsnew/3.12.rst
eb6ad56 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

hugovk commented Jun 4, 2022

Copy link
Copy Markdown
Member

cc also PEP-594 co-author @brettcannon.

brettcannon requested changes Jun 8, 2022
View reviewed changes

brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

Comment thread Lib/test/test_logging.py

bedevere-bot commented Jun 8, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

arhadthedev commented Jun 8, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

bedevere-bot commented Jun 8, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

bedevere-bot requested a review from brettcannon June 8, 2022 21:17

arhadthedev commented Jul 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

@vsajip @warsaw could you review and possibly merge this PR please? It deletes smtpd tests in advance and, for consistency, makes the module private by moving it into Lib/test/smtpd.py.

This is necessary to allow further reviewable-sized PRs (one for each SMTP* class moved into its consumer in test) without massive changes of Lib/test/test_smtpd.py for synchronization.

warsaw requested changes Aug 4, 2022
View reviewed changes

warsaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I have a small rewording request.

Comment thread Doc/whatsnew/3.12.rst Outdated

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

arhadthedev commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon, @warsaw: please review the changes made to this pull request.

bedevere-bot requested a review from warsaw August 4, 2022 19:25
Update 3.12.rst
e351af3 
Wording suggestion.

brettcannon commented Aug 5, 2022

Copy link
Copy Markdown
Member

@warsaw not sure if this is showing up in your review queue as the GH UI is not letting me re-request your review.

Update 3.12.rst
1d157ec 
Small reword suggestion.

warsaw commented Aug 6, 2022

Copy link
Copy Markdown
Member

Thanks for the ping @brettcannon - I'm good with this, with my one edit to the source branch. I thought I'd pushed that through previously, but upon further review, it doesn't look like it stuck. Trying that again...

warsaw approved these changes Aug 6, 2022
View reviewed changes

warsaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Okay, this time it looks like my small wording edit got committed. Thanks for the contribution @arhadthedev ! Approving and setting the automerge label.

miss-islington commented Aug 6, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅ .

miss-islington merged commit 56d16e8 into python:main Aug 6, 2022
arhadthedev deleted the privatize-smtpd branch August 7, 2022 06:55
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
pythongh-93243: Make smtpd private before porting its users (pythonGH…
10dc75f 
…-93246)

pythongh-93243

This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).

Automerge-Triggered-By: GH:warsaw
sobolevn mentioned this pull request Sep 5, 2022
Merged
arhadthedev mentioned this pull request Oct 6, 2022
Closed
12 tasks
hugovk mentioned this pull request Oct 28, 2022
Closed
vstinner mentioned this pull request Nov 8, 2022
Closed
sobolevn mentioned this pull request Jan 21, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
AA-Turner AA-Turner left review comments
warsaw warsaw approved these changes
vsajip Awaiting requested review from vsajip vsajip is a code owner
brettcannon Awaiting requested review from brettcannon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL