gh-93345: Fix a crash in substitution of nested TypeVar after TypeVarTuple - #93346
Merged
serhiy-storchaka merged 3 commits intoMay 31, 2022
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
marked this pull request as ready for review
May 30, 2022 07:25
serhiy-storchaka
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
May 30, 2022 07:25
Fidget-Spinner
approved these changes
May 30, 2022
Comment thread
Misc/NEWS.d/next/Core and Builtins/2022-05-30-10-22-46.gh-issue-93345.gi1A4L.rst
Outdated
…e-93345.gi1A4L.rst Co-authored-by: Ken Jin <kenjin4096@gmail.com>
Copy link
Copy Markdown
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
serhiy-storchaka
deleted the
typing-subst-nested-typevar-after-typevartuple
branch
May 31, 2022 05:46
Copy link
Copy Markdown
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 1, 2022
…ypeVarTuple (pythonGH-93346) For example: tuple[*Ts, list[T]][int, str, bool] (cherry picked from commit f545fc9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
GH-93402 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93345.