Doc: Disable smartquotes for zh-tw and fr translations. - #9337
Doc: Disable smartquotes for zh-tw and fr translations.#9337JulienPalard wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
@adrianliaw can you please test a build with this patch and validate it fixes zh-tw quote issues? |
Sorry, something went wrong.
|
It works perfectly for our build. Thank you @JulienPalard for the PR! As a side note, previously the issue occurred in the translation of tutorial/venv.rst where: pip has a number of subcommands: “search”, “install”, “uninstall”, “freeze”, etc. was translated into: pip 有好幾個子指令："search"、"install"、"uninstall"、"freeze" 等等。 but output as pip 有好幾個子指令：」search」、」install」、」uninstall」、」freeze」 等等。 Now by applying this PR, this issue doesn't raise again. |
Sorry, something went wrong.
willingc
left a comment
There was a problem hiding this comment.
Looks good. Thanks @JulienPalard. I'll leave this for you to merge.
Sorry, something went wrong.
|
I prefer the #9423 version, so I close mine. |
Sorry, something went wrong.
This is a replacement for python#9337. * Using conf.py to disable smartquotes through Sphinx instead of using docutils.conf * Disable smartquotes for Japanese, French and Traditional Chinese translations See: * Suggesting to use conf.py: https://mail.python.org/pipermail/doc-sig/2018-September/004084.html * Original smartquotes issue in ja translations: https://bugs.python.org/issue31793 * Disabling for ja: python#4006 * Smartquotes issue in fr: python/python-docs-fr#303 * Smartquotes issue in zh_TW: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
See: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
and: #4006