FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-61585: Clarify import scope in modules tutorial by slateny · Pull Request #93455 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-61585: Clarify import scope in modules tutorial - #93455

Merged
ambv merged 4 commits into
python:mainfrom
slateny:s/61585
Jun 28, 2022
ConversationCommits (4)ChecksFiles changed
Merged

gh-61585: Clarify import scope in modules tutorial#93455
ambv merged 4 commits into
python:mainfrom
slateny:s/61585

Conversation

slateny commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 3, 2022
AA-Turner reviewed Jun 8, 2022
View reviewed changes
Comment thread Doc/tutorial/modules.rst Outdated
Use namespace instead of symbol table
52ac1f8 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

AA-Turner commented Jun 12, 2022

Copy link
Copy Markdown
Member

Should the other four usages of symbol table be adjusted in this PR?

A

CAM-Gerlach commented Jun 13, 2022

Copy link
Copy Markdown
Member

Should the other four usages of symbol table be adjusted in this PR?

That might be a little scope-creepy, but since all the usages in this file are fairly nearby this one, that would avoid any introduced inconsistency, if @slateny is okay with doing so.

If so, then I suggest making the first reference in the previous section a link to the term :term:`Namespace`, and then the move the :term:`namespace` (see :ref:`tut-scopes` for more details). line to the first usage (which describes it in some detail) in this section. That would be a better place to put it anyway, really, since it explicitly introduces the basic concept.

CAM-Gerlach reviewed Jun 15, 2022
View reviewed changes

CAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Update the wording of the lines to match the new word used, as the old dict wasn't really grammatically appropriate after the change. Otherwise, LGTM, thanks.

Comment thread Doc/tutorial/modules.rst Outdated
Comment thread Doc/tutorial/modules.rst Outdated
Comment thread Doc/tutorial/modules.rst Outdated
Change 'enters' to 'adds'
c37485f 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach approved these changes Jun 25, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for the delay—LGTM now from my end, thanks!

JelleZijlstra self-requested a review June 25, 2022 01:43
JelleZijlstra self-assigned this Jun 25, 2022
ambv merged commit 4b854b7 into python:main Jun 28, 2022

miss-islington commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

Thanks @slateny for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2022
pythongh-61585: Clarify import scope in modules tutorial (pythonGH-93455
d9bef8a 
)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b854b7)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>

bedevere-bot commented Jun 28, 2022

Copy link
Copy Markdown

GH-94373 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 28, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2022
pythongh-61585: Clarify import scope in modules tutorial (pythonGH-93455
4a178bd 
)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b854b7)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>

bedevere-bot commented Jun 28, 2022

Copy link
Copy Markdown

GH-94374 is a backport of this pull request to the 3.10 branch.

ambv pushed a commit that referenced this pull request Jun 28, 2022
gh-61585: Clarify import scope in modules tutorial (GH-93455) (GH-94373)
3937dbf 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
(cherry picked from commit 4b854b7)
ambv pushed a commit that referenced this pull request Jun 28, 2022
gh-61585: Clarify import scope in modules tutorial (GH-93455) (GH-94374)
d11b010 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
(cherry picked from commit 4b854b7)
ambv mentioned this pull request Jun 28, 2022
Closed
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
pythongh-61585: Clarify import scope in modules tutorial (pythonGH-93455
b5942e9 
)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
slateny deleted the s/61585 branch September 24, 2022 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
JelleZijlstra JelleZijlstra approved these changes
CAM-Gerlach CAM-Gerlach approved these changes
+1 more reviewer
DanielNoord DanielNoord approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL