FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617) by miss-islington · Pull Request #93651 · python/cpython · GitHub

/ cpython Public

[3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617) - #93651

Merged
miss-islington merged 1 commit into
python:3.11from
miss-islington:backport-30610d2-3.11
Jun 10, 2022
ConversationCommits (1)ChecksFiles changed
Merged

[3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617)#93651
miss-islington merged 1 commit into
python:3.11from
miss-islington:backport-30610d2-3.11

Conversation

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

Co-authored-by: XD Trol milestonejxd@gmail.com
Co-authored-by: Antoine Pitrou pitrou@free.fr
(cherry picked from commit 30610d2)

Co-authored-by: Leo Trol milestone.jxd@gmail.com

pythongh-90549: Fix leak of global named resources using multiprocess…
54e06c1 
…ing spawn (pythonGH-30617)

Co-authored-by: XD Trol <milestonejxd@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
(cherry picked from commit 30610d2)

Co-authored-by: Leo Trol <milestone.jxd@gmail.com>
miss-islington requested a review from 1st1 as a code owner June 9, 2022 16:55

ghost commented Jun 9, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

bedevere-bot mentioned this pull request Jun 9, 2022
Merged

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

pitrou commented Jun 9, 2022

Copy link
Copy Markdown
Member

@vstinner Do you know why we get a CLA signing failure here that did not exist on the original PR?

vstinner commented Jun 9, 2022

Copy link
Copy Markdown
Member

Co-authored-by: XD Trol milestonejxd@gmail.com

vs

The following commit authors need to sign the Contributor License Agreement: milestone.jxd@gmail.com

One email has a dot, not the other. I don't know what's going on.

@ambv: Do you have an idea why the email address is different and the CLA check fails?

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

jxdabc commented Jun 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Co-authored-by: XD Trol milestonejxd@gmail.com

vs

The following commit authors need to sign the Contributor License Agreement: milestone.jxd@gmail.com

One email has a dot, not the other. I don't know what's going on.

@ambv: Do you have an idea why the email address is different and the CLA check fails?

CLA fixed. It seems that Github auto-generated commits ignore dots in email addresses, but the CLA bot does not.

cc @vstinner @pitrou

pitrou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 10, 2022

bedevere-bot commented Jun 10, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pitrou for commit 54e06c1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 10, 2022

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

vstinner approved these changes Jun 10, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, backport from main branch.

ambv commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

The CLA bot should probably also ignore dots in emails.

ambv commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local ~/.gitconfig email address and the GitHub account email address?

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a pending ❌ .

pitrou commented Jun 10, 2022

Copy link
Copy Markdown
Member

test_signal has been running for 28 min on the remaining buildbot... Is it ok to merge nevertheless? @vstinner

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

miss-islington merged commit aee7d3d into python:3.11 Jun 10, 2022
miss-islington deleted the backport-30610d2-3.11 branch June 10, 2022 15:05

ambv commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

@pitrou In my experience the buildbots get added in waves so the fact that there is "just one left" isn't enough to merge early. In this case miss-islington already merged so hopefully we went through all of them.

ambv mentioned this pull request Jun 11, 2022
Closed

jxdabc commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local ~/.gitconfig email address and the GitHub account email address?

Yes, the email address in ~/.gitconfig does differ from GitHub account email address.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
pitrou pitrou approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL