[3.11] gh-91317: Document that Path does not collapse initial // (GH-32193) - #93702
Merged
miss-islington merged 1 commit intoJun 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…thonGH-32193) Documentation for `pathlib` says: > Spurious slashes and single dots are collapsed, but double dots ('..') are not, since this would change the meaning of a path in the face of symbolic links: However, it omits that initial double slashes also aren't collapsed. Later, in documentation of `PurePath.drive`, `PurePath.root`, and `PurePath.name` it mentions UNC but: - this abbreviation says nothing to a person who is unaware about existence of UNC (Wikipedia doesn't help either by [giving a disambiguation page](https://en.wikipedia.org/wiki/UNC)) - it shows up only if a person needs to use a specific property or decides to fully learn what the module provides. For context, see the BPO entry. (cherry picked from commit 78f1a43) Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Copy link
Copy Markdown
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
brettcannon
approved these changes
Jun 10, 2022
Copy link
Copy Markdown
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for pathlib says:
However, it omits that initial double slashes also aren't collapsed.
Later, in documentation of PurePath.drive, PurePath.root, and PurePath.name it mentions UNC but:
For context, see the BPO entry.
(cherry picked from commit 78f1a43)
Co-authored-by: Oleg Iarygin oleg@arhadthedev.net
Automerge-Triggered-By: GH:brettcannon