FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-93939: Build most shared extensions without setup.py by tiran · Pull Request #93940 · python/cpython · GitHub

/ cpython Public

gh-93939: Build most shared extensions without setup.py - #93940

Closed
tiran wants to merge 6 commits into
python:mainfrom
tiran:gh-93939-setup-stdlib
Closed

gh-93939: Build most shared extensions without setup.py#93940
tiran wants to merge 6 commits into
python:mainfrom
tiran:gh-93939-setup-stdlib

Conversation

tiran commented Jun 17, 2022
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

tiran commented Jun 17, 2022

Copy link
Copy Markdown
Member Author

macOS builder fails with sed: 13: @sed.in.11268: extra characters at the end of h command in configure step. Could somebody with a Mac please debug the problem?

tiran force-pushed the gh-93939-setup-stdlib branch from 7cb1c1f to e45af20 Compare June 26, 2022 08:40
Comment thread Tools/scripts/check_shared_ext.py Outdated
tiran force-pushed the gh-93939-setup-stdlib branch 6 times, most recently from 27867a5 to ea81ed8 Compare June 28, 2022 20:29

Copy link
Copy Markdown
Member

macOS builder fails with sed: 13: @sed.in.11268: extra characters at the end of h command in configure step. Could somebody with a Mac please debug the problem?

macOS uses a BSD-based version of sed and apparently an old version at that. There are a number of documented differences among the various versions and I think you are running into one by trying to do the multi-line append here:

		echo "/Definitions added by makesetup/a$NL$NL$DEFS" >>$sedf
		cat $sedf

Searching the web, there are various ways suggested to do this in a manner that will work with all versions. One simple way that seemed to work with both the macOS and GNU versions is to write the contents of $DEFS to another temp file and then use the sed r command instead of a to insert them.

tiran commented Jun 29, 2022

Copy link
Copy Markdown
Member Author

Thanks @ned-deily! sed r command works like a charm.

tiran force-pushed the gh-93939-setup-stdlib branch from 60d4b36 to 4af2830 Compare June 29, 2022 08:14
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 4af2830c1cdfdc4a3a0fc0e5a8f491fa09301b14 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
tiran force-pushed the gh-93939-setup-stdlib branch from 4af2830 to 6502e8c Compare June 29, 2022 10:11
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 6502e8c76540e19b489e8aab31801d88cf1986ed 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022

tiran commented Jul 5, 2022

Copy link
Copy Markdown
Member Author

The PR was an experiment. I'll open a proper PR when everything is in place.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL