FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Document 3.13, 3.14, 4.0 and future removals by hugovk · Pull Request #93986 · python/cpython · GitHub

/ cpython Public

Document 3.13, 3.14, 4.0 and future removals - #93986

Closed
hugovk wants to merge 8 commits into
python:mainfrom
hugovk:document-pending-removals
ConversationCommits (8)ChecksFiles changed
Closed

Document 3.13, 3.14, 4.0 and future removals#93986
hugovk wants to merge 8 commits into
python:mainfrom
hugovk:document-pending-removals

Conversation

hugovk commented Jun 18, 2022 •
edited by gpshead
Loading

Copy link
Copy Markdown
Member

Follow on from #92308.

This lists in the What's New page some more deprecations pending removal in:

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 18, 2022

warsaw commented Jun 18, 2022

Copy link
Copy Markdown
Member

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen? Like, maybe a JSON file or some such where the deprecations are recorded (or a script to parse the docs or code). Then, when the new version is created at main, the automation would open some release blockers on those deprecations. What do you think?

arhadthedev commented Jun 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@warsaw Probably, grepping docs for .. deprecated-removed:: and headers for Py_DEPRECATED would be better than maintaining another list file.

Edit: for \.\. deprecated-removed:: [^ ]+ (\d+).(\d+) and Py_DEPRECATED\((\d+).(\d+)\).

hugovk commented Jun 19, 2022

Copy link
Copy Markdown
Member Author

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

Yes, using the new warnings._deprecated method will make it clear with RuntimeErrors after the relevant alpha: https://discuss.python.org/t/introducing-warnings-deprecated/14856

hauntsaninja reviewed Jun 20, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
hugovk mentioned this pull request Jul 29, 2022
Closed

ezio-melotti commented Jul 29, 2022

Copy link
Copy Markdown
Member

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

See also:

ezio-melotti reviewed Jul 29, 2022
View reviewed changes

ezio-melotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I left a comment and a couple of minor suggestions -- feel free to disregard them if you think the current version is better.

Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Doc/whatsnew/3.12.rst Outdated
Improve wording and linking
6f28fb9 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti mentioned this pull request Aug 4, 2022
Closed
ezio-melotti reviewed Aug 11, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated

CAM-Gerlach commented Aug 11, 2022

Copy link
Copy Markdown
Member

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

You could also fire a Sphinx warning in the else branch here in the directive (with a check for whether its an alpha, and perhaps an :option: to disable it for special cases), just like warnings._deprecated does.

Whitespace fix
5787b27 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
CAM-Gerlach mentioned this pull request Aug 12, 2022
Closed
33 tasks
bdarnell reviewed Feb 7, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
:keyword:`for`, :keyword:`if`, :keyword:`in`, :keyword:`is` and :keyword:`or`.
In a future release it will be changed to a syntax error. (:gh:`87999`)

* :func:`asyncio.get_event_loop` emits a :exc:`DeprecationWarning` if there is

bdarnell Feb 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The deprecation plans for this function have changed. See #100970 for the updated deprecation notice.

hugovk Feb 7, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the note! This PR has got pretty out of date...

hugovk mentioned this pull request May 26, 2023
Merged

hugovk commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Will try again in a new PR :)

hugovk closed this Aug 16, 2023
hugovk deleted the document-pending-removals branch August 16, 2023 19:19
hugovk mentioned this pull request Aug 16, 2023
Merged

hugovk commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Please see PR #108055 instead 🚀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja left review comments
ezio-melotti ezio-melotti left review comments
+1 more reviewer
bdarnell bdarnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL