FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-93991: Use boolean instead of 0/1 for condition check by leikdga · Pull Request #93992 · python/cpython · GitHub

/ cpython Public

gh-93991: Use boolean instead of 0/1 for condition check #93992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 2 commits into from
Jun 19, 2022
Conversation 8 Commits 2 Checks 0 Files changed
Merged

gh-93991: Use boolean instead of 0/1 for condition check #93992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab2752
Use boolean instead of 0/1 for condition check
leikdga Jun 18, 2022
b6355d0
Fix coding style for a function default parameter
leikdga Jun 19, 2022
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
8 changes: 4 additions & 4 deletions Lib/filecmp.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -157,17 +157,17 @@ def phase2(self): # Distinguish files, directories, funnies
a_path = os.path.join(self.left, x)
b_path = os.path.join(self.right, x)

ok = 1
ok = True
try:
a_stat = os.stat(a_path)
except OSError:
# print('Can\'t stat', a_path, ':', why.args[1])
ok = 0
ok = False
try:
b_stat = os.stat(b_path)
except OSError:
# print('Can\'t stat', b_path, ':', why.args[1])
ok = 0
ok = False

if ok:
a_type = stat.S_IFMT(a_stat.st_mode)
Expand Down Expand Up @@ -242,7 +242,7 @@ def report_full_closure(self): # Report on self and subdirs recursively

methodmap = dict(subdirs=phase4,
same_files=phase3, diff_files=phase3, funny_files=phase3,
common_dirs = phase2, common_files=phase2, common_funny=phase2,
common_dirs=phase2, common_files=phase2, common_funny=phase2,
common=phase1, left_only=phase1, right_only=phase1,
left_list=phase0, right_list=phase0)

Expand Down
Back | FazBrowse Home | New Git URL