[3.10] gh-61162: Clarify sqlite3 connection context manager docs (GH-93890) - #94012
Merged
miss-islington merged 1 commit intoJun 19, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…onGH-93890) Explicitly note that transactions are only closed if there is an open transation at `__exit__`, and that transactions are not implicitly opened during `__enter__`. Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com> Automerge-Triggered-By: GH:erlend-aasland (cherry picked from commit 8e08978) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington
requested review from
berkerpeksag and
erlend-aasland
as code owners
June 19, 2022 20:17
Copy link
Copy Markdown
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
erlend-aasland
approved these changes
Jun 19, 2022
Copy link
Copy Markdown
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly note that transactions are only closed if there is an open
transation at __exit__, and that transactions are not implicitly
opened during __enter__.
Co-authored-by: CAM Gerlach CAM.Gerlach@Gerlach.CAM
Co-authored-by: Stanley 46876382+slateny@users.noreply.github.com
Automerge-Triggered-By: GH:erlend-aasland
(cherry picked from commit 8e08978)
Co-authored-by: Erlend Egeberg Aasland erlend.aasland@protonmail.com