FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-94018: Remove trailing spaces in _sanitize_windows_name by Rygone · Pull Request #94040 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-94018: Remove trailing spaces in _sanitize_windows_name - #94040

Merged
ambv merged 10 commits into
python:mainfrom
Rygone:patch-1
Jun 28, 2022
ConversationCommits (10)ChecksFiles changed
Merged

gh-94018: Remove trailing spaces in _sanitize_windows_name#94040
ambv merged 10 commits into
python:mainfrom
Rygone:patch-1

Conversation

Rygone commented Jun 20, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

ghost commented Jun 20, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

hauntsaninja commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

You'll want to rename your PR to "gh-94018 [...]" instead of "hg-94018"

Rygone changed the title hg-94018: Remove trailing spaces in _sanitize_windows_name gh-94018: Remove trailing spaces in _sanitize_windows_name Jun 20, 2022
Rygone changed the title gh-94018: Remove trailing spaces in _sanitize_windows_name [gh-94018](https://github.com/python/cpython/issues/94018): Remove trailing spaces in _sanitize_windows_name Jun 20, 2022
Rygone changed the title [gh-94018](https://github.com/python/cpython/issues/94018): Remove trailing spaces in _sanitize_windows_name gh-94018: Remove trailing spaces in _sanitize_windows_name Jun 20, 2022

bedevere-bot commented Jun 20, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Update Misc/NEWS.d/next/Windows/2022-06-20-22-32-14.gh-issue-94018.by…
29f57ee 
…cC3A.rst

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
zware requested changes Jun 21, 2022
View reviewed changes

zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There should be one or more tests added for this. See Lib/test/test_zipfile.py.

The change itself looks reasonable enough to me, but this should be reviewed by someone who is more versed in the inner workings of zip files before it is merged.

Comment thread Misc/NEWS.d/next/Windows/2022-06-20-22-32-14.gh-issue-94018.bycC3A.rst Outdated

bedevere-bot commented Jun 21, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Rygone commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Jun 23, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.

bedevere-bot requested a review from zware June 23, 2022 14:57
zware approved these changes Jun 23, 2022
View reviewed changes

zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but I'm not comfortable merging without an OK from one of our zipfile maintainers.

ambv commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

LGTM. Leading or trailing spaces (ASCII 0x20) are indeed not allowed on Windows and those characters are silently removed by the OS:
https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/file-folder-name-whitespace-characters

ambv merged commit 176fd55 into python:main Jun 28, 2022
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
pythongh-94018: Remove trailing spaces in _sanitize_windows_name (pyt…
5e9d3b6 
…honGH-94040)

Closes python#94018.

Co-authored-by: Sam Ezeh <sam.z.ezeh@gmail.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja left review comments
zware zware approved these changes
serhiy-storchaka Awaiting requested review from serhiy-storchaka
Yhg1s Awaiting requested review from Yhg1s
gpshead Awaiting requested review from gpshead
+1 more reviewer
dignissimus dignissimus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL