GH-93964: Harden overflow checks before _PyBytes_Resize in compile.c - #94044
GH-93964: Harden overflow checks before _PyBytes_Resize in compile.c#94044sweeneyde wants to merge 8 commits into
Conversation
Sorry, something went wrong.
| Py_ssize_t b_len = PyBytes_GET_SIZE(*bytes); | ||
| if (unitsize * logical_length >= b_len - to_add * unitsize) { | ||
| // There's not enough room. Double it. | ||
| if (b_len > PY_SSIZE_T_MAX / 2) { |
There was a problem hiding this comment.
This has the same issue as the backport.
We want to be able to index all code object structures with an int, so you'll need INT_MAX instead of PY_SSIZE_T_MAX and it should be an overflow error, not a memory error.
Sorry, something went wrong.
There was a problem hiding this comment.
To clarify, we want a_bytecode to be able to have INT_MAX code units, not just INT_MAX bytes, right?
Sorry, something went wrong.
There was a problem hiding this comment.
We probably want the smaller amount to avoid risk of overflow. So the length in bytes should be less than INT_MAX.
Sorry, something went wrong.
|
Is the PR still relevant or some other PR superseded this one? For merge conflict resolution: touched functions were moved to Python/assemble.c by gh-103277. cc @iritkatriel |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
#93964
The issue was found in 3.10, so it will need to be manually backported there.