FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-93771: Clarify how deepfreeze.py is run by gvanrossum · Pull Request #94150 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-93771: Clarify how deepfreeze.py is run #94150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 2 commits into from
Jun 23, 2022
Conversation 8 Commits 2 Checks 0 Files changed
Merged

gh-93771: Clarify how deepfreeze.py is run #94150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d895840
Clarify how deepfreeze.py is run
gvanrossum Jun 23, 2022
3a77a8f
Fix typo
gvanrossum Jun 23, 2022
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
6 changes: 4 additions & 2 deletions Tools/scripts/deepfreeze.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
"""Deep freeze

The script is executed by _bootstrap_python interpreter. Shared library
extension modules are not available.
The script may be executed by _bootstrap_python interpreter.

kumaraditya303 Jun 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, another thing is that even though this script is executed by _bootstrap_python with the same magic number, still it uses umarshal rather than directly using compile even though it supports both but I suppose that it would be too much info to add.

gvanrossum Jun 23, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess that code could even be removed?

kumaraditya303 Jun 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That code is useful as sometimes I used it to debug marshal output so better to leave as is.

gvanrossum Jun 23, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Okay, that's fine.
Shared library extension modules are not available in that case.
On Windows, and in cross-compilation cases, it is executed
by Python 3.10, and 3.11 features are not available.
"""
import argparse
import ast
Expand Down
Back | FazBrowse Home | New Git URL