Generalize build_msi GitHub action - #94201
Merged
ambv merged 1 commit intoJun 28, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ezio-melotti
approved these changes
Jun 24, 2022
Comment thread
.github/workflows/build_msi.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, .github/workflows/build_msi.yml has two places of duplication:
enumeration of trigger branches manually updated each minor release (['main', '3.11', '3.10', '3.9', '3.8', '3.7']) instead of permavalid wildcards (['main', '3.*']):
enumeration of three build configurations (x86, x64, arm64) that are carbon copies of each other except a title and a single command line parameter.
This PR generalizes them into a wildcard and a matrix respectively.
It also modifies the GitHub run report. Before:
After: