FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] GH-93516: Backport GH-93769 by markshannon · Pull Request #94231 · python/cpython · GitHub

/ cpython Public

[3.11] GH-93516: Backport GH-93769 - #94231

Merged
markshannon merged 6 commits into
python:3.11from
faster-cpython:backport-93769
Jun 28, 2022
ConversationCommits (6)ChecksFiles changed
Merged

[3.11] GH-93516: Backport GH-93769#94231
markshannon merged 6 commits into
python:3.11from
faster-cpython:backport-93769

Conversation

markshannon commented Jun 24, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Reduces the overhead of dispatching in DO_TRACING considerably.

My informal measures on the test program in #93516 (comment) show that this reduces execution time by about 10%

@pablogsal Should I regenerate the ABI for this PR?

arhadthedev commented Jun 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Probably the issue should be renamed to ... Backport GH-93769 for a clickable number in https://github.com/python/cpython/commits/main (though, it's just a nitpick).

markshannon changed the title [3.11] GH-93516: Backport 93769 [3.11] GH-93516: Backport GH-93769 Jun 24, 2022
Fidget-Spinner mentioned this pull request Jun 25, 2022
Open

markshannon commented Jun 28, 2022

Copy link
Copy Markdown
Member Author

@pablogsal I'd like to get this merged, as it will be needed for the backport of #94371

pablogsal reviewed Jun 28, 2022
View reviewed changes
Comment thread Tools/scripts/deepfreeze.py
pablogsal approved these changes Jun 28, 2022
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me 👍

pablogsal commented Jun 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@pablogsal Should I regenerate the ABI for this PR?

I can try to do it for you. Otherwise you can follow these instructions:

@pablogsal Should I regenerate the ABI for this PR?

pablogsal commented Jun 28, 2022

Copy link
Copy Markdown
Member

I cannot push to the PR, but you can copy this commit into yours if you want:

pablogsal@8380dd0

markshannon commented Jun 28, 2022

Copy link
Copy Markdown
Member Author

Hmm, I followed the instructions, yet a0ced71 is clearly different to pablogsal@8380dd0

markshannon commented Jun 28, 2022

Copy link
Copy Markdown
Member Author

I see, it is because of the assert changing the line numbers.
Why does an application binary interface include line numbers?

pablogsal commented Jun 28, 2022

Copy link
Copy Markdown
Member

Why does an application binary interface include line numbers?

Those are not taken into account when checking it. They just come from the DWARF if I am not mistaken

pablogsal approved these changes Jun 28, 2022
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM !

markshannon merged commit 3b4f5ed into python:3.11 Jun 28, 2022
markshannon deleted the backport-93769 branch September 26, 2023 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL