FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-87347: Fix PyObject_NEW() regression by vstinner · Pull Request #94234 · python/cpython · GitHub

/ cpython Public

gh-87347: Fix PyObject_NEW() regression - #94234

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:object_new
Jun 26, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-87347: Fix PyObject_NEW() regression#94234
vstinner merged 1 commit into
python:mainfrom
vstinner:object_new

Conversation

vstinner commented Jun 24, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Don't add parenthesis around the type parameter.

Add unit tests on PyObject_NEW() and similar functions.

vstinner marked this pull request as ready for review June 24, 2022 16:49
vstinner mentioned this pull request Jun 24, 2022
Closed

vstinner commented Jun 24, 2022

Copy link
Copy Markdown
Member Author

cc @corona10

vstinner mentioned this pull request Jun 24, 2022
Closed
corona10 approved these changes Jun 24, 2022
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!

kumaraditya303 reviewed Jun 24, 2022
View reviewed changes
Comment thread Modules/_testcapimodule.c Outdated

kumaraditya303 Jun 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unused macro?

erlend-aasland Jun 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like leftovers from an early revision. I'm sure Victor will remove it before merging.

vstinner Jun 26, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops, I forgot about it. That's why reviews are great :-) I removed this unused macro. I used if+goto instead of the macro.

gh-87347: Fix PyObject_NEW() regression
72abb20 
Don't add parenthesis around the type parameter.

Add unit tests on PyObject_NEW() and similar functions.
vstinner merged commit 44c8e68 into python:main Jun 26, 2022
vstinner deleted the object_new branch June 26, 2022 10:40

vstinner commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

Merged, thanks for reviews!

vstinner commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

Oops, my test leaks 4 references: I wrote PR #94330 to fix it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
corona10 corona10 approved these changes
kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL