FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-89988: Fix memory leak in pickle.Pickler dispatch_table lookup by kumaraditya303 · Pull Request #94298 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-89988: Fix memory leak in pickle.Pickler dispatch_table lookup - #94298

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
kumaraditya303:memleak-pickle
Jun 28, 2022
ConversationCommits (2)ChecksFiles changed
Merged

GH-89988: Fix memory leak in pickle.Pickler dispatch_table lookup#94298
serhiy-storchaka merged 2 commits into
python:mainfrom
kumaraditya303:memleak-pickle

Conversation

kumaraditya303 commented Jun 26, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

kumaraditya303 self-assigned this Jun 26, 2022
kumaraditya303 added needs backport to 3.10 extension-modules C modules in the Modules dir needs backport to 3.11 only security fixes labels Jun 26, 2022
serhiy-storchaka approved these changes Jun 28, 2022
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

serhiy-storchaka merged commit 01ef1f9 into python:main Jun 28, 2022

miss-islington commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

Sorry, @kumaraditya303 and @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 01ef1f95dab9c9930ce1a23634a3e5a8331bf3c7 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2022
pythonGH-89988: Fix memory leak in pickle.Pickler dispatch_table look…
d771639 
…up (pythonGH-94298)

(cherry picked from commit 01ef1f9)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 28, 2022

bedevere-bot commented Jun 28, 2022

Copy link
Copy Markdown

GH-94365 is a backport of this pull request to the 3.11 branch.

serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 28, 2022
kumaraditya303 deleted the memleak-pickle branch June 28, 2022 13:12
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jun 28, 2022
pythonGH-89988: Fix memory leak in pickle.Pickler dispatch_table look…
ccaa5ea 
…up (pythonGH-94298)

bedevere-bot commented Jun 28, 2022

Copy link
Copy Markdown

GH-94385 is a backport of this pull request to the 3.10 branch.

pablogsal pushed a commit that referenced this pull request Jun 28, 2022
[3.10] GH-89988: Fix memory leak in pickle.Pickler dispatch_table loo…
079ea44 
…kup (GH-94298) (#94385)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
pythonGH-89988: Fix memory leak in pickle.Pickler dispatch_table look…
8699848 
…up (pythonGH-94298)
miss-islington added a commit that referenced this pull request Jul 14, 2022
GH-89988: Fix memory leak in pickle.Pickler dispatch_table lookup (GH…
91f7914 
…-94298)

(cherry picked from commit 01ef1f9)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
serhiy-storchaka removed their assignment Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
erlend-aasland Awaiting requested review from erlend-aasland

Assignees

No one assigned

Labels

extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL