| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
It would be more consistent to increase the indentation in other part of the example.
Sorry, something went wrong.
|
Oh, good point, I didn't compare it to the other code blocks in that file. Yeah, I suppose it would be slightly more consistent, although I see two, three, four, and five spaces of indentation relative to the preceding paragraphs... It seems like three is the most common though, and that's what the dev guide says as well (three spaces in reST, 4 spaces inside the Python blocks, but the indentation of the code blocks would be part of reST syntax). I'll normalise the entire document to use three for consistency. |
Sorry, something went wrong.
|
I don’t think the churn is worth it. This will not change the output, nor help developers. |
Sorry, something went wrong.
|
I mostly agree with @merwok -- the churn is too large, and in most cases it does not affect the output. But in two cases, in the original code example and in the versionchanged directive for asynccontextmanager, incorrect indentation affects the output. It is a bug which should be fixed. I may miss other such cases, please re-check me. |
Sorry, something went wrong.
|
@JustAnotherArchivist Are you still interested in combing through the docs for whitespace / visible formatting changes? I think the important ones listed here are the original stray space and also some three-space indentation in code examples. Another possible change is to remove the >>> from code examples as it doesn't help much with copying: |
Sorry, something went wrong.
I think that’s been addressed quite some time ago: there is now a formatting that adds buttons to toggle prompts on/off, and easily copy the code block. |
Sorry, something went wrong.
Sorry, something went wrong.
|
I'll start on a new PR here then and close this when that one's open - let me know if you'd still like to continue this one. |
Sorry, something went wrong.
|
Apologies, I hadn't seen the notification emails for this for some reason. I disagree with the 'churn' argument, but that's a bit late now. Thanks for the fix, @slateny! |
Sorry, something went wrong.
|
No worries, thanks for the update 🙂 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
There was a stray space at the beginning of some lines in the async @timeit example.
As this is a trivial typo fix, no issue exists, and a news entry shouldn't be necessary.