FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] GH-93896: Always set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) by miss-islington · Pull Request #94608 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.11] GH-93896: Always set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) - #94608

Merged
miss-islington merged 1 commit into
python:3.11from
miss-islington:backport-14fea6b-3.11
Jul 6, 2022
ConversationCommits (1)ChecksFiles changed
Merged

[3.11] GH-93896: Always set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593)#94608
miss-islington merged 1 commit into
python:3.11from
miss-islington:backport-14fea6b-3.11

Conversation

miss-islington commented Jul 6, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

pythonGH-93896: AAlways set event loop in asyncio.run and IsolatedAsy…
d347aa7 
…ncioTestCase (pythonGH-94593)

(cherry picked from commit 14fea6b)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

bedevere-bot mentioned this pull request Jul 6, 2022
Merged

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 6 of 9 required status checks are expected..

kumaraditya303 approved these changes Jul 6, 2022
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

kumaraditya303 commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

The title has a typo, would be nice to fix it. (I cannot edit).

pablogsal changed the title [3.11] GH-93896: AAlways set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) [3.11] GH-93896: Always set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) Jul 6, 2022

pablogsal commented Jul 6, 2022

Copy link
Copy Markdown
Member

Done 👍

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

miss-islington merged commit 0187b60 into python:3.11 Jul 6, 2022
miss-islington deleted the backport-14fea6b-3.11 branch July 6, 2022 15:48
kumaraditya303 mentioned this pull request Jul 6, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

asvetlov asvetlov approved these changes
pablogsal pablogsal approved these changes
kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL