FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-94321: Document sqlite3.PrepareProtocol by erlend-aasland · Pull Request #94620 · python/cpython · GitHub

/ cpython Public

gh-94321: Document sqlite3.PrepareProtocol - #94620

Merged
erlend-aasland merged 5 commits into
python:mainfrom
erlend-aasland:sqlite-doc-prepareprotocol
Jul 7, 2022
ConversationCommits (5)ChecksFiles changed
Merged

gh-94321: Document sqlite3.PrepareProtocol#94620
erlend-aasland merged 5 commits into
python:mainfrom
erlend-aasland:sqlite-doc-prepareprotocol

Conversation

erlend-aasland commented Jul 6, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland linked an issue Jul 6, 2022 that may be closed by this pull request
Document sqlite3.PrepareProtocol #94321
Closed
erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes skip news docs Documentation in the Doc dir labels Jul 6, 2022
CAM-Gerlach requested changes Jul 7, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe worth adding a NEWS entry?

Comment thread Modules/_sqlite/prepare_protocol.c Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated

erlend-aasland commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

Maybe worth adding a NEWS entry?

Yeah, I thought about that myself.

erlend-aasland commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

FYI, I'm merging this later tonight.

erlend-aasland mentioned this pull request Jul 7, 2022
Closed
CAM-Gerlach reviewed Jul 7, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm still a little confused—is sqlite3.PrepareProtocol a type of "Blob Object"? I assumed it wasn't, which motivated my suggested change to add its own section heading, since its currently under the "Blob Object" section. Just to confirm—I was mistaken about that?

erlend-aasland commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

Aaaaah, I missed adding the header. Sorry!

CAM-Gerlach approved these changes Jul 7, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM now, thanks @erlend-aasland !

erlend-aasland merged commit fb6dcca into python:main Jul 7, 2022

miss-islington commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-doc-prepareprotocol branch July 7, 2022 22:33
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2022
pythongh-94321: Document sqlite3.PrepareProtocol (pythonGH-94620)
41166c7 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

miss-islington commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fb6dccae348b954d9f625031b54711a9a33da525 3.10

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 7, 2022

bedevere-bot commented Jul 7, 2022

Copy link
Copy Markdown

GH-94670 is a backport of this pull request to the 3.11 branch.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 7, 2022
[3.10] pythongh-94321: Document sqlite3.PrepareProtocol (pythonGH-94620…
d168606 
…).

(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

bedevere-bot commented Jul 7, 2022

Copy link
Copy Markdown

GH-94671 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 7, 2022
erlend-aasland mentioned this pull request Jul 7, 2022
Closed
miss-islington added a commit that referenced this pull request Jul 7, 2022
gh-94321: Document sqlite3.PrepareProtocol (GH-94620)
c72001e 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jul 7, 2022
[3.10] gh-94321: Document sqlite3.PrepareProtocol (GH-94620) (#94671)
797745e 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CAM-Gerlach CAM-Gerlach approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

erlend-aasland

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document sqlite3.PrepareProtocol

4 participants

Back | FazBrowse Home | New Git URL