FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-94713 - Replacing while 1 with while True by Nougat-Waffle · Pull Request #94714 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-94713 - Replacing while 1 with while True - #94714

Merged
rhettinger merged 2 commits into
python:mainfrom
Nougat-Waffle:gh-94713/modernize-platform-code
Jul 13, 2022
ConversationCommits (2)ChecksFiles changed
Merged

gh-94713 - Replacing while 1 with while True#94714
rhettinger merged 2 commits into
python:mainfrom
Nougat-Waffle:gh-94713/modernize-platform-code

Conversation

Nougat-Waffle commented Jul 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

gh-94713: Replacing %-formatting and string concatenation with f-strings and replacing while 1 with while True.

I don't think there is a need for a NEWS entry.

bedevere-bot commented Jul 9, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Nougat-Waffle changed the title Replacing %-formatting and string concatenation with f-strings in platform module gh-94713 - Replacing %-formatting and string concatenation with f-strings in platform module Jul 9, 2022

ericvsmith commented Jul 9, 2022

Copy link
Copy Markdown
Member

Typically we don't accept changes like this, due to the churn involved. Is there any reason these need to be f-strings?

Nougat-Waffle commented Jul 9, 2022

Copy link
Copy Markdown
Contributor Author

Typically we don't accept changes like this, due to the churn involved. Is there any reason these need to be f-strings?

These don't need to be f-strings. I just though that changing to f-strings would make the code better and so I did. Could u elaborate further on why changes like this aren't welcome ?

ericvsmith commented Jul 9, 2022

Copy link
Copy Markdown
Member

Could u elaborate further on why changes like this aren't welcome ?

There's always a chance for an error to be introduced in corner cases, and it makes any existing PRs difficult to apply.

I'd definitely be okay with the 1 -> True change, though.

Nougat-Waffle commented Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'd definitely be okay with the 1 -> True change, though.

Alright, I reverted back the f-strings changes.

DanielNoord approved these changes Jul 12, 2022
View reviewed changes

DanielNoord left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Although the name of this PR should probably be updated.

Nougat-Waffle changed the title gh-94713 - Replacing %-formatting and string concatenation with f-strings in platform module gh-94713 - Replacing while 1 with while True Jul 12, 2022
rhettinger merged commit cceac5d into python:main Jul 13, 2022
Nougat-Waffle deleted the gh-94713/modernize-platform-code branch July 13, 2022 04:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
DanielNoord DanielNoord approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL