FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-34762: Fix contextvars C API to use PyObject* pointer types. by 1st1 · Pull Request #9473 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-34762: Fix contextvars C API to use PyObject* pointer types. - #9473

Merged
1st1 merged 3 commits into
python:masterfrom
1st1:fix567
Sep 21, 2018
ConversationCommits (3)ChecksFiles changed
Merged

bpo-34762: Fix contextvars C API to use PyObject* pointer types.#9473
1st1 merged 3 commits into
python:masterfrom
1st1:fix567

Conversation

1st1 commented Sep 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Member
  • Note: if this PR is accepted I'll update the docs before merging it.

https://bugs.python.org/issue34762

vstinner approved these changes Sep 21, 2018
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

1st1 commented Sep 21, 2018

Copy link
Copy Markdown
Member Author

@elprans Please take a look at the docs update (and PR in general).

1st1 commented Sep 21, 2018

Copy link
Copy Markdown
Member Author

This is how the docs section looks when rendered:

elprans approved these changes Sep 21, 2018
View reviewed changes
Comment thread Doc/c-api/contextvars.rst Outdated
1st1 merged commit 2ec872b into python:master Sep 21, 2018

miss-islington commented Sep 21, 2018

Copy link
Copy Markdown
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

1st1 deleted the fix567 branch September 21, 2018 19:34
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2018
bpo-34762: Fix contextvars C API to use PyObject* pointer types. (pyt…
54e4a89 
…honGH-9473)

(cherry picked from commit 2ec872b)

Co-authored-by: Yury Selivanov <yury@magic.io>

bedevere-bot commented Sep 21, 2018

Copy link
Copy Markdown

GH-9478 is a backport of this pull request to the 3.7 branch.

1st1 commented Sep 21, 2018

Copy link
Copy Markdown
Member Author

Thanks everybody for reviews!

miss-islington added a commit that referenced this pull request Sep 21, 2018
bpo-34762: Fix contextvars C API to use PyObject* pointer types. (GH-…
187f2dd 
…9473)

(cherry picked from commit 2ec872b)

Co-authored-by: Yury Selivanov <yury@magic.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
asvetlov asvetlov approved these changes
rhettinger rhettinger approved these changes
+1 more reviewer
elprans elprans approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL