gh-90815: Fix test_embed for Windows PGO build with mimalloc - #94790
Merged
miss-islington merged 3 commits intoJul 13, 2022
Merged
gh-90815: Fix test_embed for Windows PGO build with mimalloc#94790miss-islington merged 3 commits into
miss-islington merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@ericsnowcurrently Could you take a look at this patch, please? |
Sorry, something went wrong.
kumaraditya303
approved these changes
Jul 13, 2022
Copy link
Copy Markdown
Member
|
@neonene This looks like a general fix that should be backported to 3.11 and 3.10, too. Do you agree? |
Sorry, something went wrong.
tiran
approved these changes
Jul 13, 2022
Copy link
Copy Markdown
Contributor
Author
|
I agree. This patch would be better for profiling on 3.11 and 3.10. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @neonene for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-94805 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-94806 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2022
…ythonGH-94790) Fixes the failure of PGO building with `mimalloc` on Windows, ensuring that `test_bpo20891` does not break profiling data (`python31*.pgc`). (cherry picked from commit 4a6bb30) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2022
…ythonGH-94790) Fixes the failure of PGO building with `mimalloc` on Windows, ensuring that `test_bpo20891` does not break profiling data (`python31*.pgc`). (cherry picked from commit 4a6bb30) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jul 13, 2022
Fixes the failure of PGO building with `mimalloc` on Windows, ensuring that `test_bpo20891` does not break profiling data (`python31*.pgc`). (cherry picked from commit 4a6bb30) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jul 13, 2022
Fixes the failure of PGO building with `mimalloc` on Windows, ensuring that `test_bpo20891` does not break profiling data (`python31*.pgc`). (cherry picked from commit 4a6bb30) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failure of PGO building with mimalloc on Windows, ensuring that test_bpo20891 does not break profiling data (python31*.pgc).
Automerge-Triggered-By: GH:tiran