FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-94808: Cover handling non-finite numbers from round when ndigits is provided by mdboom · Pull Request #94860 · python/cpython · GitHub

/ cpython Public

gh-94808: Cover handling non-finite numbers from round when ndigits is provided - #94860

Merged
brandtbucher merged 1 commit into
python:mainfrom
mdboom:coverage-floatobject
Jul 14, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-94808: Cover handling non-finite numbers from round when ndigits is provided#94860
brandtbucher merged 1 commit into
python:mainfrom
mdboom:coverage-floatobject

Conversation

mdboom commented Jul 14, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

This is an interesting corner case.

By default round returns int which can't represent non-finite numbers, so it throws various exceptions.

When ndigits is provided, round returns float, so non-finite numbers can be represented, and they just return what was passed in.

Automerge-Triggered-By: GH:brandtbucher

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 14, 2022
mdboom mentioned this pull request Jul 14, 2022
Open
brandtbucher approved these changes Jul 14, 2022
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Interesting indeed!

brandtbucher merged commit 625ba9b into python:main Jul 14, 2022
brandtbucher added needs backport to 3.11 only security fixes and removed 🤖 automerge labels Jul 14, 2022

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2022

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

GH-94882 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2022
pythonGH-94808: Cover handling non-finite numbers from round when ndi…
4d0c077 
…gits is provided (pythonGH-94860)

(cherry picked from commit 625ba9b)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
miss-islington added a commit that referenced this pull request Jul 15, 2022
[3.11] GH-94808: Cover handling non-finite numbers from round when nd…
e55f60d 
…igits is provided (GH-94860) (GH-94882)

(cherry picked from commit 625ba9b)


Co-authored-by: Michael Droettboom <mdboom@gmail.com>

Automerge-Triggered-By: GH:brandtbucher
mdboom added the needs backport to 3.11 only security fixes label Aug 8, 2022

miss-islington commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Sorry, @mdboom and @brandtbucher, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 625ba9bdff51baddf9d5e156e5facf05fa1003d6 3.11

mdboom removed the needs backport to 3.11 only security fixes label Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher approved these changes

Assignees

brandtbucher

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL