gh-81040: Improve sqlite3.Cursor.rowcount docs - #94940
Merged
erlend-aasland merged 2 commits intoJul 22, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
erlend-aasland
commented
Jul 17, 2022
Comment thread
Doc/library/sqlite3.rst
CAM-Gerlach
reviewed
Jul 22, 2022
CAM-Gerlach
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
A few minor suggested tweaks, otherwise LGTM, thanks
Sorry, something went wrong.
Comment thread
Doc/library/sqlite3.rst
Outdated
Comment thread
Doc/library/sqlite3.rst
Outdated
Comment thread
Doc/library/sqlite3.rst
Outdated
Comment thread
Doc/library/sqlite3.rst
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, CAM! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 22, 2022
(cherry picked from commit f9b3706) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Copy link
Copy Markdown
|
GH-95124 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 22, 2022
(cherry picked from commit f9b3706) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Copy link
Copy Markdown
|
GH-95125 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
added a commit
that referenced
this pull request
Jul 22, 2022
miss-islington
added a commit
that referenced
this pull request
Jul 22, 2022
5 tasks
AlexWaygood
removed their request for review
July 28, 2022 00:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves gh-81040