FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-94851: check refcnt of immortal objects after finalization by kumaraditya303 · Pull Request #95001 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-94851: check refcnt of immortal objects after finalization - #95001

Merged
miss-islington merged 5 commits into
python:mainfrom
kumaraditya303:global-objects
Jul 25, 2022
ConversationCommits (5)ChecksFiles changed
Merged

GH-94851: check refcnt of immortal objects after finalization#95001
miss-islington merged 5 commits into
python:mainfrom
kumaraditya303:global-objects

Conversation

kumaraditya303 commented Jul 19, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Automerge-Triggered-By: GH:ericsnowcurrently

kumaraditya303 force-pushed the global-objects branch 2 times, most recently from 41d0cfc to f66d0ce Compare July 20, 2022 06:40
kumaraditya303 mentioned this pull request Jul 20, 2022
Merged
kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2022

bedevere-bot commented Jul 20, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 21ced2f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2022
kumaraditya303 marked this pull request as ready for review July 20, 2022 14:49
ericsnowcurrently requested changes Jul 21, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Other than one small thing, LGTM. I suspect we will rip this out once (if) PEP 683 lands. Even then this is a helpful stopgap.

Comment thread Tools/scripts/generate_global_objects.py Outdated

bedevere-bot commented Jul 21, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ericsnowcurrently requested changes Jul 22, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for adding the constant! There's a comment to add and then this should be ready to merge.

Comment thread Include/internal/pycore_object.h
Update Include/internal/pycore_object.h
be56017 
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently approved these changes Jul 25, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

miss-islington merged commit 73ee5a6 into python:main Jul 25, 2022
kumaraditya303 deleted the global-objects branch July 25, 2022 17:44

kumaraditya303 commented Jul 25, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews @ericsnowcurrently!

kumaraditya303 mentioned this pull request Jul 25, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes
+1 more reviewer
tiran tiran left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL