FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly by iritkatriel · Pull Request #95107 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly - #95107

Merged
iritkatriel merged 11 commits into
python:mainfrom
iritkatriel:cfg_struct
Jul 26, 2022
ConversationCommits (11)ChecksFiles changed
Merged

gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly#95107
iritkatriel merged 11 commits into
python:mainfrom
iritkatriel:cfg_struct

Conversation

iritkatriel commented Jul 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This further decouples the compiler struct from parts of the compilation process, and in particular enables CFG construction without a compiler (which is useful for unit tests).

iritkatriel requested a review from markshannon as a code owner July 21, 2022 20:09
iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 21, 2022
iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 21, 2022

bedevere-bot commented Jul 21, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4bbebf8 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 21, 2022
iritkatriel mentioned this pull request Jul 21, 2022
Closed
markshannon reviewed Jul 25, 2022
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One question

Comment thread Python/compile.c Outdated
iritkatriel changed the title gh-93678: extract 'struct cfg' from the compiler so that the CFG can be manipulated directly gh-93678: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly Jul 26, 2022

iritkatriel commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

@markshannon Any more comments on this?

markshannon approved these changes Jul 26, 2022
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FTR, I'd prefer we pass locations by value, but no need to do that for this PR.

iritkatriel commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

FTR, I'd prefer we pass locations by value, but no need to do that for this PR.

Sure, might as well do it here.

iritkatriel merged commit 75c0c1b into python:main Jul 26, 2022
iritkatriel deleted the cfg_struct branch July 26, 2022 13:36
iritkatriel mentioned this pull request Jul 27, 2022
Closed
iritkatriel changed the title gh-93678: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL