FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95166: cancel map waited on future on timeout by graingert · Pull Request #95169 · python/cpython · GitHub

/ cpython Public

gh-95166: cancel map waited on future on timeout - #95169

Merged
ambv merged 8 commits into
python:mainfrom
graingert:cancel-map-future-on-timeout
Jul 28, 2022
ConversationCommits (8)ChecksFiles changed
Merged

gh-95166: cancel map waited on future on timeout#95169
ambv merged 8 commits into
python:mainfrom
graingert:cancel-map-future-on-timeout

Conversation

graingert commented Jul 23, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

graingert commented Jul 23, 2022
View reviewed changes
Comment thread Lib/test/test_concurrent_futures.py Outdated
graingert commented Jul 23, 2022
View reviewed changes
Comment thread Lib/test/test_concurrent_futures.py Outdated
graingert commented Jul 23, 2022
View reviewed changes
Comment thread Lib/test/test_concurrent_futures.py Outdated
graingert commented Jul 23, 2022
View reviewed changes
Comment thread Lib/test/test_concurrent_futures.py Outdated
graingert marked this pull request as ready for review July 23, 2022 19:15
graingert requested a review from kumaraditya303 July 23, 2022 19:15
kumaraditya303 approved these changes Jul 24, 2022
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 24, 2022
Update Misc/NEWS.d/next/Library/2022-07-23-10-42-05.gh-issue-95166.xw…
f5b7372 
…6p3C.rst

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
ambv self-requested a review July 26, 2022 10:29
ambv merged commit e16d4ed into python:main Jul 28, 2022

miss-islington commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

Thanks @graingert for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2022
pythongh-95166: cancel map waited on future on timeout (pythonGH-95169)
e789fb7 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
(cherry picked from commit e16d4ed)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>

bedevere-bot commented Jul 28, 2022

Copy link
Copy Markdown

GH-95364 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 28, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2022
pythongh-95166: cancel map waited on future on timeout (pythonGH-95169)
a4ca7fb 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
(cherry picked from commit e16d4ed)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>

bedevere-bot commented Jul 28, 2022 •
edited by ambv
Loading

Copy link
Copy Markdown

GH-95365 is a backport of this pull request to the 3.10 branch.

#95375 is the backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 28, 2022
ambv pushed a commit that referenced this pull request Jul 28, 2022
gh-95166: cancel map waited on future on timeout (GH-95169) (GH-95364)
763801a 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
(cherry picked from commit e16d4ed)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 28, 2022
pythongh-95166: cancel map waited on future on timeout (pythonGH-95169)
f1f0f9a 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
graingert deleted the cancel-map-future-on-timeout branch July 28, 2022 21:02
ambv added a commit that referenced this pull request Jul 29, 2022
[3.10] gh-95166: cancel map waited on future on timeout (GH-95169) (G…
1841885 
…H-95375)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
This was referenced Mar 23, 2025
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes
ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL