FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95273: Normalise sqlite3 reference wording by erlend-aasland · Pull Request #95274 · python/cpython · GitHub

/ cpython Public

gh-95273: Normalise sqlite3 reference wording - #95274

Merged
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:sqlite-reference/be-consistent
Jul 27, 2022
ConversationCommits (10)ChecksFiles changed
Merged

gh-95273: Normalise sqlite3 reference wording#95274
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:sqlite-reference/be-consistent

Conversation

erlend-aasland commented Jul 26, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 26, 2022
erlend-aasland commented Jul 26, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
erlend-aasland commented Jul 26, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst
erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 26, 2022
CAM-Gerlach reviewed Jul 27, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, just a few minor comments

Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
AlexWaygood reviewed Jul 27, 2022
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good; a few small points

Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
AlexWaygood reviewed Jul 27, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
Missed one spot
4cf5af4 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood approved these changes Jul 27, 2022
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice!

erlend-aasland commented Jul 27, 2022

Copy link
Copy Markdown
Contributor Author

Great, thanks again, both of you!

erlend-aasland merged commit 2361908 into python:main Jul 27, 2022

miss-islington commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-reference/be-consistent branch July 27, 2022 13:24

miss-islington commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2361908a9d5553102f2b2294af44852a76d2ab03 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2022
pythongh-95273: Normalise sqlite3 reference wording (pythonGH-95274)
540833f 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 27, 2022

bedevere-bot commented Jul 27, 2022

Copy link
Copy Markdown

GH-95329 is a backport of this pull request to the 3.11 branch.

bedevere-bot commented Jul 27, 2022

Copy link
Copy Markdown

GH-95330 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 27, 2022
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jul 27, 2022
[3.10] pythongh-95273: Normalise sqlite3 reference wording (pythonGH-…
056afa8 
…95274)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>.
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
miss-islington added a commit that referenced this pull request Jul 27, 2022
gh-95273: Normalise sqlite3 reference wording (GH-95274)
e14c4d5 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland pushed a commit that referenced this pull request Jul 27, 2022
[3.10] gh-95273: Normalise sqlite3 reference wording (GH-95274) (#95330)
2ef7a72 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>.
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CAM-Gerlach CAM-Gerlach left review comments
AlexWaygood AlexWaygood approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

erlend-aasland

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

5 participants

Back | FazBrowse Home | New Git URL