FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95273: Improve sqlite3 class descriptions by erlend-aasland · Pull Request #95379 · python/cpython · GitHub

/ cpython Public

gh-95273: Improve sqlite3 class descriptions - #95379

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:sqlite-reference/class-description
Jul 29, 2022
ConversationCommits (4)ChecksFiles changed
Merged

gh-95273: Improve sqlite3 class descriptions#95379
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:sqlite-reference/class-description

Conversation

erlend-aasland commented Jul 28, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 28, 2022
bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 28, 2022

erlend-aasland commented Jul 28, 2022

Copy link
Copy Markdown
Contributor Author

I'm not satisfied with the connection and cursor wordings, but this is as far as I could get. I've borrowed slightly from the SQLite docs and PEP 249.

erlend-aasland commented Jul 28, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
erlend-aasland commented Jul 28, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst
This was referenced Jul 28, 2022
Closed
Merged
CAM-Gerlach reviewed Jul 29, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A handful of minor comments, but otherwise LGTM—thanks, @erlend-aasland

Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated

erlend-aasland commented Jul 29, 2022

Copy link
Copy Markdown
Contributor Author

I've addressed all review comments; will land as soon as the CI is green.

erlend-aasland commented Jul 29, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
erlend-aasland commented Jul 29, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
erlend-aasland merged commit e003b64 into python:main Jul 29, 2022

miss-islington commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-reference/class-description branch July 29, 2022 09:53

bedevere-bot commented Jul 29, 2022

Copy link
Copy Markdown

GH-95425 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 29, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2022
pythongh-95273: Improve sqlite3 class descriptions (pythonGH-95379)
2cee5f3 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit e003b64)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2022
pythongh-95273: Improve sqlite3 class descriptions (pythonGH-95379)
c92fec9 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit e003b64)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented Jul 29, 2022

Copy link
Copy Markdown

GH-95426 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 29, 2022
miss-islington added a commit that referenced this pull request Jul 29, 2022
gh-95273: Improve sqlite3 class descriptions (GH-95379)
a41b51d 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit e003b64)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull request Jul 29, 2022
gh-95273: Improve sqlite3 class descriptions (GH-95379)
c26470f 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit e003b64)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag Awaiting requested review from berkerpeksag
CAM-Gerlach Awaiting requested review from CAM-Gerlach

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

4 participants

Back | FazBrowse Home | New Git URL