FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95273: Condense sqlite3 executescript example by erlend-aasland · Pull Request #95383 · python/cpython · GitHub

/ cpython Public

gh-95273: Condense sqlite3 executescript example - #95383

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:sqlite-reference/condense-executescript-example
Jul 29, 2022
ConversationCommits (2)ChecksFiles changed
Merged

gh-95273: Condense sqlite3 executescript example#95383
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:sqlite-reference/condense-executescript-example

Conversation

erlend-aasland commented Jul 28, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 28, 2022
erlend-aasland added docs Documentation in the Doc dir skip news labels Jul 28, 2022
erlend-aasland mentioned this pull request Jul 28, 2022
Closed
5 tasks

erlend-aasland commented Jul 28, 2022

Copy link
Copy Markdown
Contributor Author

Also, the current example is faulty bco. lack of transaction handling: there is no commit; the connection is closed with a pending transaction.

erlend-aasland commented Jul 28, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst
CAM-Gerlach reviewed Jul 29, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, aside from one comment responding to yours

Comment thread Doc/library/sqlite3.rst
erlend-aasland mentioned this pull request Jul 29, 2022
Merged

erlend-aasland commented Jul 29, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review, CAM!

erlend-aasland merged commit e9c8de6 into python:main Jul 29, 2022

miss-islington commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-reference/condense-executescript-example branch July 29, 2022 07:40
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2022
pythongh-95273: Condense sqlite3 executescript example (pythonGH-95383)
08d7e30 
(cherry picked from commit e9c8de6)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented Jul 29, 2022

Copy link
Copy Markdown

GH-95418 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 29, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2022
pythongh-95273: Condense sqlite3 executescript example (pythonGH-95383)
61ac35d 
(cherry picked from commit e9c8de6)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented Jul 29, 2022

Copy link
Copy Markdown

GH-95419 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 29, 2022
miss-islington added a commit that referenced this pull request Jul 29, 2022
gh-95273: Condense sqlite3 executescript example (GH-95383)
6eae15a 
(cherry picked from commit e9c8de6)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland pushed a commit that referenced this pull request Jul 29, 2022
gh-95273: Condense sqlite3 executescript example (GH-95383) (#95419)
2278dc7 
(cherry picked from commit e9c8de6)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CAM-Gerlach CAM-Gerlach left review comments
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

4 participants

Back | FazBrowse Home | New Git URL