FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] bpo-34791: xml package obeys ignore env flags (GH-9544) by miss-islington · Pull Request #9545 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.7] bpo-34791: xml package obeys ignore env flags (GH-9544) - #9545

Merged
vstinner merged 1 commit into
python:3.7from
miss-islington:backport-223e501-3.7
Oct 19, 2018
ConversationCommits (1)ChecksFiles changed
Merged

[3.7] bpo-34791: xml package obeys ignore env flags (GH-9544)#9545
vstinner merged 1 commit into
python:3.7from
miss-islington:backport-223e501-3.7

Conversation

miss-islington commented Sep 24, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The xml.sax and xml.dom.domreg modules now obey
sys.flags.ignore_environment.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue34791
(cherry picked from commit 223e501)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue34791

bpo-34791: xml package obeys ignore env flags (pythonGH-9544)
ad074cb 
The xml.sax and xml.dom.domreg modules now obey
sys.flags.ignore_environment.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue34791
(cherry picked from commit 223e501)

Co-authored-by: Christian Heimes <christian@python.org>
bedevere-bot mentioned this pull request Sep 24, 2018
Merged

miss-islington commented Sep 24, 2018

Copy link
Copy Markdown
Contributor Author

@tiran: Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented Sep 24, 2018

Copy link
Copy Markdown
Contributor Author

@tiran: Status check is done, and it's a success ✅ .

ned-deily commented Oct 6, 2018

Copy link
Copy Markdown
Member

@tiran Is this ready to merge to 3.7?

vstinner merged commit c119d59 into python:3.7 Oct 19, 2018
miss-islington deleted the backport-223e501-3.7 branch October 19, 2018 23:09

vstinner commented Oct 19, 2018

Copy link
Copy Markdown
Member

@tiran: adding the "automerge" label doesn't work on automatically merge a PR once the CI pass. "automerge" still requires that a core dev approves the PR.

For backports created by @miss-islington, approving the PR is enough: the "automerge" label is not needed.

vstinner commented Oct 19, 2018

Copy link
Copy Markdown
Member

@tiran Is this ready to merge to 3.7?

He already approved the backport by adding the "automerge" label, except that technically it wasn't enough to automatically merge the PR.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL