Repository navigation
gh-95511: IDLE - fix Shell context menu copy-with-prompts bug - #95512
Merged
terryjreedy merged 2 commits intoAug 1, 2022
Merged
terryjreedy merged 2 commits into
terryjreedy merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
If one selects whole lines, as the sidebar makes easy, do not add an extra line. Only move the end of a selection to the beginning of the next line when not already at the beginning of a line. (Also improve the surrounding code.)
Copy link
Copy Markdown
Member
Author
|
I made extensive manual tests before making the PR, and it is those, along with logic, that convince me that the patch is correct. The existing test_copy_with_prompts required the buggy behavior until I fixed it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-95519 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 1, 2022
…ythonGH-95512) If one selects whole lines, as the sidebar makes easy, do not add an extra line. Only move the end of a selection to the beginning of the next line when not already at the beginning of a line. (Also improve the surrounding code.) (cherry picked from commit fc31a13) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 1, 2022
…ythonGH-95512) If one selects whole lines, as the sidebar makes easy, do not add an extra line. Only move the end of a selection to the beginning of the next line when not already at the beginning of a line. (Also improve the surrounding code.) (cherry picked from commit fc31a13) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Copy link
Copy Markdown
|
GH-95520 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
added a commit
that referenced
this pull request
Aug 1, 2022
If one selects whole lines, as the sidebar makes easy, do not add an extra line. Only move the end of a selection to the beginning of the next line when not already at the beginning of a line. (Also improve the surrounding code.) (cherry picked from commit fc31a13) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Aug 1, 2022
If one selects whole lines, as the sidebar makes easy, do not add an extra line. Only move the end of a selection to the beginning of the next line when not already at the beginning of a line. (Also improve the surrounding code.) (cherry picked from commit fc31a13) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one selects whole lines, as the sidebar makes easy, do not
add an extra line. Only move the end of a selection to the
beginning of the next line when not already at the beginning
of a line. (Also improve the surrounding code.)