FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95271: Extract placeholders howto from sqlite3 tutorial by erlend-aasland · Pull Request #95522 · python/cpython · GitHub

/ cpython Public

gh-95271: Extract placeholders howto from sqlite3 tutorial - #95522

Merged
erlend-aasland merged 8 commits into
python:mainfrom
erlend-aasland:sqlite-tutorial/extract-placeholders
Aug 4, 2022
ConversationCommits (8)ChecksFiles changed
Merged

gh-95271: Extract placeholders howto from sqlite3 tutorial#95522
erlend-aasland merged 8 commits into
python:mainfrom
erlend-aasland:sqlite-tutorial/extract-placeholders

Conversation

erlend-aasland commented Aug 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes gh-95271

erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Aug 1, 2022
bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Aug 1, 2022
erlend-aasland mentioned this pull request Aug 1, 2022
Closed

erlend-aasland commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

The placeholders howto can get an overhaul in a separate PR; for now, just move it.

CAM-Gerlach requested changes Aug 2, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Given the stated scope of this PR I won't comment on anything but the move, but there is one pretty important thing missing—the section heading for the new How-To section :)

Otherwise, LGTM within the stated scope.

Comment thread Doc/library/sqlite3.rst
ezio-melotti reviewed Aug 2, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
CAM-Gerlach approved these changes Aug 3, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM from me, thanks, aside from what @ezio-melotti pointed out

CAM-Gerlach approved these changes Aug 3, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One minor comment, otherwise LGTM for now—thanks @erlend-aasland !

Comment thread Doc/library/sqlite3.rst Outdated
Use literal question mark
1d840ca 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

erlend-aasland commented Aug 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'll wait for Ezio's thumbs-up before landing, since he requested this change in the first place.

ezio-melotti reviewed Aug 3, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
Consistency FTW
86d86c0 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

erlend-aasland commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

FYI, landing this tonight (CET).

erlend-aasland commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews, both of you! Having more eyes helps 👀

erlend-aasland merged commit b24e8b2 into python:main Aug 4, 2022

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-tutorial/extract-placeholders branch August 4, 2022 20:41

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

GH-95677 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 4, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 4, 2022
[3.11] pythongh-95271: Extract placeholders howto from sqlite3 tutori…
9d3e42f 
…al (pythonGH-95522)

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit b24e8b2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 4, 2022
[3.10] pythongh-95271: Extract placeholders howto from sqlite3 tutori…
705f579 
…al (pythonGH-95522)

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit b24e8b2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 4, 2022

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

GH-95678 is a backport of this pull request to the 3.10 branch.

erlend-aasland added a commit that referenced this pull request Aug 4, 2022
[3.10] gh-95271: Extract placeholders howto from sqlite3 tutorial (GH…
54ea127 
…-95522) (#95678)

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit b24e8b2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Aug 4, 2022
[3.11] gh-95271: Extract placeholders howto from sqlite3 tutorial (GH…
4d37b42 
…-95522) (#95677)

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit b24e8b2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
pythongh-95271: Extract placeholders howto from sqlite3 tutorial (pyt…
96b7ac5 
…hon#95522)

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ezio-melotti ezio-melotti left review comments
CAM-Gerlach CAM-Gerlach approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 tutorial

5 participants

Back | FazBrowse Home | New Git URL