FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95273: Clarify when the sqlite_* attributes are added to sqlite3 exceptions by erlend-aasland · Pull Request #95523 · python/cpython · GitHub

/ cpython Public

gh-95273: Clarify when the sqlite_* attributes are added to sqlite3 exceptions - #95523

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:sqlite-reference/improve-exception-accuracy
Aug 1, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-95273: Clarify when the sqlite_* attributes are added to sqlite3 exceptions#95523
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:sqlite-reference/improve-exception-accuracy

Conversation

erlend-aasland commented Aug 1, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Aug 1, 2022
bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Aug 1, 2022
erlend-aasland mentioned this pull request Aug 1, 2022
Closed
5 tasks
AlexWaygood approved these changes Aug 1, 2022
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That was an easy one to review!

erlend-aasland commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

That was an easy one to review!

I remembered you said you were swamped with work at the moment, so I took the chance with a small PR :)

erlend-aasland merged commit 1e6b635 into python:main Aug 1, 2022

miss-islington commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-reference/improve-exception-accuracy branch August 1, 2022 09:15

miss-islington commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1e6b63542e4856436c5c12148a6608ef9d148b71 3.10

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 1, 2022

bedevere-bot commented Aug 1, 2022

Copy link
Copy Markdown

GH-95524 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
pythongh-95273: Clarify when sqlite_* attributes are added to sqlite3…
f947a2e 
… exceptions (pythonGH-95523)

(cherry picked from commit 1e6b635)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks
erlend-aasland removed the needs backport to 3.10 only security fixes label Aug 1, 2022

erlend-aasland commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

Removing 3.10 backport, as 3.10 does not have this feature.

miss-islington added a commit that referenced this pull request Aug 1, 2022
gh-95273: Clarify when sqlite_* attributes are added to sqlite3 excep…
ad2872f 
…tions (GH-95523)

(cherry picked from commit 1e6b635)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

erlend-aasland

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

4 participants

Back | FazBrowse Home | New Git URL