gh-95504: Fix negative numbers in PyUnicode_FromFormat - #95848
Merged
encukou merged 3 commits intoAug 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
philg314
approved these changes
Aug 10, 2022
philg314
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
There are some minor adjustment to the news entries based on the news entries for the %% changes but other than that everything is in order. Thank you!
Sorry, something went wrong.
Comment thread
Doc/whatsnew/3.12.rst
Outdated
Comment thread
Misc/NEWS.d/next/C API/2022-07-31-21-58-27.gh-issue-95504.wy7B1F.rst
Outdated
Co-authored-by: philg314 <110174000+philg314@users.noreply.github.com>
philg314
reviewed
Aug 10, 2022
Comment thread
Doc/whatsnew/3.12.rst
Outdated
| copied as-is to the result string, and any extra arguments discarded. | ||
| (Contributed by Serhiy Storchaka in :gh:`95781`.) | ||
|
|
||
| * Fixed wrong sign placement in :c:func:`PyUnicode_FromFormat` and |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Oh, no problem! I'm just not a fan of the nitpycky tests :)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the non-refactoring part of #95505.
(Plus the ACKS fixup I forgot to include in #95819 😅)