FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-90928: Improve static initialization of keywords tuple in AC by erlend-aasland · Pull Request #95907 · python/cpython · GitHub

/ cpython Public

gh-90928: Improve static initialization of keywords tuple in AC - #95907

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:improve-gh-95860
Aug 13, 2022
ConversationCommits (6)ChecksFiles changed
Merged

gh-90928: Improve static initialization of keywords tuple in AC#95907
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:improve-gh-95860

Conversation

erlend-aasland commented Aug 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Calculate num_keywords during template generation instead of leaving it to the preprocessor. This makes for much smaller and easier to read (FWIW) AC output.

See discussion in #95860 (comment)

erlend-aasland mentioned this pull request Aug 11, 2022
Merged
erlend-aasland marked this pull request as ready for review August 11, 2022 22:51
ericsnowcurrently requested changes Aug 11, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for working on this! Mostly LGTM.

Also, can you drop "num_keywords" from template_dict now?

Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated

bedevere-bot commented Aug 11, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

erlend-aasland commented Aug 11, 2022

Copy link
Copy Markdown
Contributor Author

Also, can you drop "num_keywords" from template_dict now?

It is already dropped :)

erlend-aasland commented Aug 11, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

bedevere-bot commented Aug 11, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

kumaraditya303 self-requested a review August 12, 2022 17:09
ericsnowcurrently approved these changes Aug 12, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

I'll leave it up to you about the two comments I left.

Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Update Tools/clinic/clinic.py
f1d533c 
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
erlend-aasland commented Aug 12, 2022
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated

erlend-aasland commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing; highly appreciated. I'll make a quick adjustment before landing.

Address last round of reviews
8915c05 
- inline len(keywords)
- use NUM_KEYWORDS constant for improved readability in generated code

erlend-aasland commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

I'm done with the last round of adjustments. I ended up adding both of your last suggestions. Thanks again.

erlend-aasland commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

FYI, I'll wait with merging until Kumar has finished his review.

kumaraditya303 approved these changes Aug 13, 2022
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

erlend-aasland commented Aug 13, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!

erlend-aasland merged commit f07adf8 into python:main Aug 13, 2022
erlend-aasland deleted the improve-gh-95860 branch August 13, 2022 10:10
erlend-aasland mentioned this pull request Aug 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes
kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL