FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-96073: Fix wild replacement in formatannotation by iyume · Pull Request #96074 · python/cpython · GitHub

/ cpython Public

GH-96073: Fix wild replacement in formatannotation - #96074

Merged
JelleZijlstra merged 6 commits into
python:mainfrom
iyume:patch-4
Oct 7, 2022
ConversationCommits (6)ChecksFiles changed
Merged

GH-96073: Fix wild replacement in formatannotation#96074
JelleZijlstra merged 6 commits into
python:mainfrom
iyume:patch-4

Conversation

iyume commented Aug 18, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot commented Aug 18, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

sobolevn reviewed Aug 29, 2022
View reviewed changes

sobolevn left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please, don't forget to add news and tests.

I also think that proposed solution can be simplified?

I propose adding a new module to test it, something like:

        new file:   Lib/test/typingdata/__init__.py
        new file:   Lib/test/typingdata/typing.py

In the future we can even more all ann_modules there 🤔

iyume commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

@sobolevn I have added some test based on your suggestion.

gvanrossum removed their request for review August 29, 2022 15:18
JelleZijlstra reviewed Aug 31, 2022
View reviewed changes
Comment thread Lib/inspect.py Outdated
JelleZijlstra reviewed Aug 31, 2022
View reviewed changes
Comment thread Lib/test/typingdata/typing.py Outdated
iyume requested review from JelleZijlstra and removed request for Fidget-Spinner August 31, 2022 07:14
sobolevn reviewed Aug 31, 2022
View reviewed changes
Comment thread Lib/test/typinganndata/inspect.py Outdated
iyume requested review from sobolevn and removed request for JelleZijlstra September 3, 2022 12:42
JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 7, 2022
JelleZijlstra merged commit d5fea01 into python:main Oct 7, 2022

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @iyume for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot commented Oct 7, 2022

Copy link
Copy Markdown

GH-98045 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…
ec569d1 
…honGH-96074)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <iyumelive@gmail.com>
bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 7, 2022

bedevere-bot commented Oct 7, 2022

Copy link
Copy Markdown

GH-98046 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…
d58c82e 
…honGH-96074)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <iyumelive@gmail.com>
miss-islington added a commit that referenced this pull request Oct 7, 2022
GH-96073: Fix wild replacement in inspect.formatannotation (GH-96074)
107ba92 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <iyumelive@gmail.com>
miss-islington added a commit that referenced this pull request Oct 7, 2022
GH-96073: Fix wild replacement in inspect.formatannotation (GH-96074)
a3a3701 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <iyumelive@gmail.com>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…
41b8172 
…hon#96074)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
sobolevn Awaiting requested review from sobolevn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL