FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-96121: Merge sqlite3.Row examples by erlend-aasland · Pull Request #96122 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-96121: Merge sqlite3.Row examples - #96122

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:sqlite-docs/row-example
Aug 22, 2022
ConversationCommits (6)ChecksFiles changed
Merged

gh-96121: Merge sqlite3.Row examples#96122
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:sqlite-docs/row-example

Conversation

erlend-aasland commented Aug 19, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • Merge sqlite3.Row examples
  • Remove the how-to and incorporate it into the reference

erlend-aasland linked an issue Aug 19, 2022 that may be closed by this pull request
Merge sqlite3.Row (reference) example with the Row How-to Guide #96121
Closed
ezio-melotti reviewed Aug 19, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst
ezio-melotti reviewed Aug 20, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
Update Doc/library/sqlite3.rst
48dc7d9 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
CAM-Gerlach reviewed Aug 20, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
CAM-Gerlach approved these changes Aug 20, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems like @ezio-melotti already addressed everything important, so just a couple trivial nits (I was slightly confused by the description of keys(), but that seems a bit out of scope here.

Erlend E. Aasland and others added 2 commits August 20, 2022 09:25
Update Doc/library/sqlite3.rst
f83999f 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Update Doc/library/sqlite3.rst
6ea9b18 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

CAM-Gerlach commented Aug 20, 2022

Copy link
Copy Markdown
Member

GitHub screwed up my review again, though I think I at least know what it was this time—simply replying to another review comment in one tab with the Comments view open with another in the Files view, which is rather silly.

erlend-aasland commented Aug 20, 2022

Copy link
Copy Markdown
Contributor Author

(I was slightly confused by the description of keys(), but that seems a bit out of scope here.

The second sentence, right? Yes, it reads ... a bit awkward.

CAM-Gerlach commented Aug 20, 2022

Copy link
Copy Markdown
Member

The second sentence, right? Yes, it reads ... a bit awkward.

Yup, in particular I didn't understand why it would only be so "Immediately after a query".

erlend-aasland mentioned this pull request Aug 22, 2022
Closed
erlend-aasland merged commit 18b1782 into python:main Aug 22, 2022

miss-islington commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-docs/row-example branch August 22, 2022 08:03

bedevere-bot commented Aug 22, 2022

Copy link
Copy Markdown

GH-96166 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2022
pythongh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (…
dcdcc8b 
…pythonGH-96122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2022
pythongh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (…
1bbf082 
…pythonGH-96122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>

bedevere-bot commented Aug 22, 2022

Copy link
Copy Markdown

GH-96167 is a backport of this pull request to the 3.10 branch.

erlend-aasland mentioned this pull request Aug 22, 2022
Closed
miss-islington added a commit that referenced this pull request Aug 22, 2022
gh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (GH-9…
a836204 
…6122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull request Aug 22, 2022
gh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (GH-9…
98622fa 
…6122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
erlend-aasland mentioned this pull request Aug 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ezio-melotti ezio-melotti left review comments
CAM-Gerlach CAM-Gerlach approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Merge sqlite3.Row (reference) example with the Row How-to Guide

5 participants

Back | FazBrowse Home | New Git URL