Repository navigation
gh-96142: add missing params to dataclass._DataclassParams - #96382
ericvsmith merged 5 commits into
Conversation
Sorry, something went wrong.
I think "include all the parameters" is a pretty defensible position too. |
Sorry, something went wrong.
ericvsmith
left a comment
There was a problem hiding this comment.
This is all great. Thanks! With the one nit about a comment, I'll accept this.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. And if you don't make the requested changes, you will be poked with soft cushions! |
Sorry, something went wrong.
|
Done! I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @ericvsmith: please review the changes made to this pull request. |
Sorry, something went wrong.
ericvsmith
left a comment
There was a problem hiding this comment.
There are some trailing spaces that are causing CI failures. I haven't actually checked every line for trailing whitespace, just the ones I quickly found (I'm working on checking out the code, but you can probably check faster than my connection can clone the code).
Sorry, something went wrong.
|
|
||
| def test_dataclass_params_repr(self): | ||
| # Even though this is testing an internal implementation detail, | ||
| # it's testing a feature we want to make sure is correctly implemented |
There was a problem hiding this comment.
There's a trailing space on this line that is causing a CI failure.
Sorry, something went wrong.
|
|
||
| def test_dataclass_params_signature(self): | ||
| # Even though this is testing an internal implementation detail, | ||
| # it's testing a feature we want to make sure is correctly implemented |
There was a problem hiding this comment.
Same thing here with a trailing space.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
Thanks everyone! |
Sorry, something went wrong.
I went with explicit .__dataclass_params__ attribute access instead of getattr(klass, _PARAMS) because it felt more safe and concete to me.
I've also considered kw_only argument by @da-woods, but it feels like _DataclassParams structure must just hold passed arguments without much logic in it. It is up to the caller to inspect kw_only on class/field.