gh-95987: Fix repr of Any type subclasses - #96412
Merged
gvanrossum merged 1 commit intoAug 30, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
sobolevn
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
August 30, 2022 08:47
Fidget-Spinner
approved these changes
Aug 30, 2022
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I didn't know you could subclass Any. However, this change LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@Fidget-Spinner this is a new feature :) |
Sorry, something went wrong.
gvanrossum
approved these changes
Aug 30, 2022
Copy link
Copy Markdown
Member
|
This doesn't qualify for backporting to 3.11.0 during the RC phase, but I would be okay if it was backported to 3.11.1 once 3.11.0 is out -- it is clearly a bugfix, just not important enough to disturb the release process. |
Sorry, something went wrong.
hauntsaninja
pushed a commit
to hauntsaninja/cpython
that referenced
this pull request
Aug 31, 2022
…96412) (cherry picked from commit 4217393) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @Gobot1234 😉