FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-96397: Document that attributes need not be identifiers by jeff5 · Pull Request #96454 · python/cpython · GitHub

/ cpython Public

gh-96397: Document that attributes need not be identifiers - #96454

Merged
gvanrossum merged 2 commits into
python:mainfrom
jeff5:doc-accept-nonid-attrs
Sep 29, 2022
ConversationCommits (2)ChecksFiles changed
Merged

gh-96397: Document that attributes need not be identifiers#96454
gvanrossum merged 2 commits into
python:mainfrom
jeff5:doc-accept-nonid-attrs

Conversation

jeff5 commented Aug 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Companion to #96393, and stemming from points made in the discussions at https://discuss.python.org/t/supporting-or-not-invalid-identifiers-in-kwargs/17147/26 and #96397, this proposes extending how we define "attribute" to match the behaviour of implementations and some current user practice.

Needs SC discussion, I believe.

Docs: attributes need not be identifiers
57522c9 
Clarify that the name of an attribute need not be a valid Python identifier, in particular through setarr(), noting that this precludes use of the dot notation to access them.
bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 31, 2022
jeff5 mentioned this pull request Aug 31, 2022
Closed
ChrisBarker-NOAA reviewed Sep 1, 2022
View reviewed changes

ChrisBarker-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me -- I've suggested a bit more verbose text, but not critical.

Comment thread Doc/library/functions.rst
Comment thread Doc/library/functions.rst
Comment thread Doc/library/functions.rst
This was referenced Sep 13, 2022
Merged
Closed

jeff5 commented Sep 29, 2022

Copy link
Copy Markdown
Contributor Author

Could this be merged, or have I more to do?

merwok requested a review from gvanrossum September 29, 2022 17:01
gvanrossum approved these changes Sep 29, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, one optional suggestion.

Comment thread Doc/glossary.rst Outdated
Mention getattr in definition of attribute
6deda04 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
gvanrossum merged commit 9a11ed8 into python:main Sep 29, 2022
gvanrossum added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Sep 29, 2022

miss-islington commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @jeff5 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @jeff5 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot commented Sep 29, 2022

Copy link
Copy Markdown

GH-97658 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Sep 29, 2022

bedevere-bot commented Sep 29, 2022

Copy link
Copy Markdown

GH-97659 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2022
pythongh-96397: Document that attributes need not be identifiers (pyt…
6f35088 
…honGH-96454)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)

Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2022
pythongh-96397: Document that attributes need not be identifiers (pyt…
9cd0c6d 
…honGH-96454)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)

Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington added a commit that referenced this pull request Sep 29, 2022
gh-96397: Document that attributes need not be identifiers (GH-96454)
27891e0 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)

Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington added a commit that referenced this pull request Sep 29, 2022
gh-96397: Document that attributes need not be identifiers (GH-96454)
0688f11 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)

Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
pythongh-96397: Document that attributes need not be identifiers (pyt…
679cf96 
…hon#96454)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
AlexWaygood mentioned this pull request Oct 11, 2022
Closed
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
gh-96397: Document that attributes need not be identifiers (GH-96454)
f20ad5e 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)

Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CAM-Gerlach CAM-Gerlach left review comments
merwok merwok approved these changes
gvanrossum gvanrossum approved these changes
+1 more reviewer
ChrisBarker-NOAA ChrisBarker-NOAA left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL