[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int() - #96501
Merged
gpshead merged 11 commits intoSep 2, 2022
Merged
[3.10] gh-95778: CVE-2020-10735: Prevent DoS by very large int()#96501gpshead merged 11 commits into
gpshead merged 11 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Co-authored-by: Christian Heimes <christian@python.org>
Ned pointed this out on the 3.7 review, it matches other patch changes and stands out better.
gpshead
marked this pull request as ready for review
September 2, 2022 05:57
gpshead
requested review from
lysnikolaou,
pablogsal,
rhettinger and
terryjreedy
as code owners
September 2, 2022 05:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer to and from text conversions via CPython's bignum int type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds.
This PR comes fresh from a pile of work done in our private PSRT security response team repo.
This backports #96499 aka 511ca94
Signed-off-by: Christian Heimes [Red Hat] christian@python.org
Tons-of-polishing-up-by: Gregory P. Smith [Google] greg@krypto.org
Reviews via the private PSRT repo via many others (see the NEWS entry in the PR).
I wrote up a one pager for the release managers.