FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.6] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) (GH-8581) by serhiy-storchaka · Pull Request #9657 · python/cpython · GitHub

Repository navigation

[3.6] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) (GH-8581) - #9657

Merged
serhiy-storchaka merged 1 commit into
python:3.6from
serhiy-storchaka:backport-47957da-3.6
Oct 11, 2018
Merged

serhiy-storchaka merged 1 commit into
python:3.6from
serhiy-storchaka:backport-47957da-3.6

Conversation

serhiy-storchaka commented Oct 1, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • help(hashlib) didn't work because of incorrect module name in blake2b and
    blake2s classes.
  • Constructors blake2*(), sha3_(), shake_() and keccak_*() incorrectly
    accepted keyword argument "string" for binary data, but documented as
    accepting the "data" keyword argument. Now this parameter is positional-only.
  • Keyword-only parameters in blake2b() and blake2s() were not documented as
    keyword-only.
  • Default value for some parameters of blake2b() and blake2s() was None,
    which is not acceptable value.
  • The length argument for shake_*.digest() was wrapped out to 32 bits.
  • The argument for shake_128.digest() and shake_128.hexdigest() was not
    positional-only as intended.
  • TypeError messages for incorrect arguments in all constructors sha3_(),
    shake_
    () and keccak_*() incorrectly referred to sha3_224.

Also made the following enhancements:

  • More accurately specified input and result types for strings, bytes and
    bytes-like objects.
  • Unified positional parameter names for update() and constructors.
  • Improved formatting.

(cherry picked from commit f1d36d8)
(cherry picked from commit 47957da)

https://bugs.python.org/issue33729

…ythonGH-8346) (pythonGH-8581)

* help(hashlib) didn't work because of incorrect module name in blake2b and
  blake2s classes.
* Constructors blake2*(), sha3_*(), shake_*() and keccak_*() incorrectly
  accepted keyword argument "string" for binary data, but documented as
  accepting the "data" keyword argument. Now this parameter is positional-only.
* Keyword-only parameters in blake2b() and blake2s() were not documented as
  keyword-only.
* Default value for some parameters of blake2b() and blake2s() was None,
  which is not acceptable value.
* The length argument for shake_*.digest() was wrapped out to 32 bits.
* The argument for shake_128.digest() and shake_128.hexdigest() was not
  positional-only as intended.
* TypeError messages for incorrect arguments in all constructors sha3_*(),
  shake_*() and keccak_*() incorrectly referred to sha3_224.

Also made the following enhancements:

* More accurately specified input and result types for strings, bytes and
  bytes-like objects.
* Unified positional parameter names for update() and constructors.
* Improved formatting.
(cherry picked from commit f1d36d8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>.
(cherry picked from commit 47957da)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot added the type-bug An unexpected behavior, bug, or error label Oct 1, 2018
serhiy-storchaka requested a review from tiran October 1, 2018 16:18
serhiy-storchaka merged commit f543e18 into python:3.6 Oct 11, 2018
serhiy-storchaka deleted the backport-47957da-3.6 branch October 11, 2018 04:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL