| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -2044,6 +2044,7 @@ Yuxiao Zeng | |
| Uwe Zessin | ||
| Cheng Zhang | ||
| George Zhang | ||
| Youfu Zhang | ||
| Charlie Zhao | ||
| Kai Zhu | ||
| Tarek Ziadé | ||
| Expand Down | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix potential deadlock in pty.spawn() |
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityWould it be okay to replace high_waterlevel and this 1024 above here with a PIPE_BUF global set to 4096 so it's clear where it comes from? This also makes the deadlock in line 164 (master_read) more apparent.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality_copy accept caller provided master_read (may be something other than pty._read). It does not support "read at most n bytes" unfortunately. The actual buffer size may exceed 4096 here. high_waterlevel serves as a threshold for whether we should continue reading into our buffer, it can not limit maximum buffer size. A name like PIPE_BUF is not appropriate per my understanding.
I do want to increase the read size from 1024 to 4096, but I'm afraid of unexpected changes to application behavior. As long as we didn't pass lots of data via pty, 1024 should serve us well. So I didn't change it.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.