FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-96636: Remove all uses of NOTRACE_DISPATCH by markshannon · Pull Request #96643 · python/cpython · GitHub

/ cpython Public

GH-96636: Remove all uses of NOTRACE_DISPATCH - #96643

Merged
markshannon merged 10 commits into
python:mainfrom
faster-cpython:remove-unsafe-notrace-dispatch
Sep 8, 2022
ConversationCommits (10)ChecksFiles changed
Merged

GH-96636: Remove all uses of NOTRACE_DISPATCH#96643
markshannon merged 10 commits into
python:mainfrom
faster-cpython:remove-unsafe-notrace-dispatch

Conversation

markshannon commented Sep 7, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

brandtbucher approved these changes Sep 7, 2022
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the quick PR!

Comment thread Lib/test/test_dynamic.py Outdated
Comment thread Misc/NEWS.d/next/Core and Builtins/2022-09-07-12-02-11.gh-issue-96636.YvN-K6.rst Outdated
Comment thread Lib/test/test_dynamic.py Outdated

mdboom commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Naive question: Do we expect this to have a performance impact, and should we measure it?

brandtbucher commented Sep 7, 2022

Copy link
Copy Markdown
Member

Mark and I both benchmarked similar changes independently this week. I saw a 0% slowdown, he saw a 1% slowdown. So the perf impact is likely <1%.

markshannon and others added 3 commits September 7, 2022 16:38
Update Lib/test/test_dynamic.py
5872b7a 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Update Misc/NEWS.d/next/Core and Builtins/2022-09-07-12-02-11.gh-issu…
7ff1782 
…e-96636.YvN-K6.rst

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Update Lib/test/test_dynamic.py
ff834d6 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Fidget-Spinner changed the title GH-96636: Remove unsafe uses of NOTRACE_DISPATCH GH-96636: Remove all uses of NOTRACE_DISPATCH Sep 7, 2022
Fidget-Spinner approved these changes Sep 7, 2022
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. The fix looks fine. Just one question about the tests.

Comment thread Lib/test/test_dynamic.py
gvanrossum reviewed Sep 7, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just nits.

Comment thread Lib/test/test_dynamic.py
Comment thread Lib/test/test_dynamic.py Outdated
Comment thread Lib/test/test_dynamic.py
Comment thread Python/ceval.c
sweeneyde reviewed Sep 7, 2022
View reviewed changes
Comment thread Python/ceval.c
markshannon added the needs backport to 3.11 only security fixes label Sep 8, 2022
markshannon merged commit aa3b4cf into python:main Sep 8, 2022

miss-islington commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker aa3b4cf779b3dddb84e094879b91703354910d8c 3.11

markshannon deleted the remove-unsafe-notrace-dispatch branch September 8, 2022 16:22
markshannon added a commit to faster-cpython/cpython that referenced this pull request Sep 8, 2022
pythonGH-96636: Remove all uses of NOTRACE_DISPATCH (pythonGH-96643)
c3e987b 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit aa3b4cf)
bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 8, 2022

bedevere-bot commented Sep 8, 2022

Copy link
Copy Markdown

GH-96688 is a backport of this pull request to the 3.11 branch.

gvanrossum pushed a commit that referenced this pull request Sep 9, 2022
[3.11] GH-96636: Remove all uses of NOTRACE_DISPATCH (GH-96643) (#96688)
5586da6 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit aa3b4cf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes
sweeneyde sweeneyde left review comments
gvanrossum gvanrossum approved these changes
brandtbucher brandtbucher approved these changes

Assignees

markshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL