gh-90994: Improve error messages upon call arguments syntax errors - #96893
Merged
lysnikolaou merged 2 commits intoNov 20, 2022
Merged
gh-90994: Improve error messages upon call arguments syntax errors#96893lysnikolaou merged 2 commits into
lysnikolaou merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I am terribly sorry for the delay @lysnikolaou. Somehow this has fly under my radar :( |
Sorry, something went wrong.
pablogsal
force-pushed
the
gh90994-call-error-messages
branch
from
5e9f6a3 to
b2286f0
Compare
November 20, 2022 20:19
Copy link
Copy Markdown
Member
|
@lysnikolaou I have fixed for you a conflict in Parser/parser.c (I have rebased this PR) |
Sorry, something went wrong.
pablogsal
approved these changes
Nov 20, 2022
pablogsal
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🚀 Excellent work!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@lysnikolaou: Status check is done, and it's a failure or timed out ❌. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the review @pablogsal! Merging this by hand since Azure pipelines failed. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automerge-Triggered-By: GH:pablogsal